Change memory setting for cnv vm for debugging.#700
Merged
libhe merged 1 commit intovirt-s1:masterfrom Mar 27, 2026
Merged
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdjusts the OpenShift test VM flavor memory configuration to use a smaller, unit-less value, likely for debugging or alignment with the target environment. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The memory value changed from
4Gi(with units) to2(unitless); please confirm this matches the expected configuration schema and runtime expectations (e.g., should this be2Gior another explicit unit) to avoid parsing or sizing issues.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The memory value changed from `4Gi` (with units) to `2` (unitless); please confirm this matches the expected configuration schema and runtime expectations (e.g., should this be `2Gi` or another explicit unit) to avoid parsing or sizing issues.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Enhancements: