Change memory to 1.5 for openshift vm.#701
Merged
libhe merged 1 commit intovirt-s1:masterfrom Mar 27, 2026
Merged
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdjusts the OpenShift VM configuration to use 1.5 units of memory instead of 2 for the 'small' flavor. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The
memoryfield was changed from an integer to a float; double-check that all consumers of this config support non-integer values and that the expected unit (e.g., GB vs GiB) is still clear and correctly interpreted. - If other VM flavor definitions exist in this repo, consider aligning their
memoryvalue types (all int or all float/strings) to avoid subtle parsing or validation inconsistencies across different environments.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The `memory` field was changed from an integer to a float; double-check that all consumers of this config support non-integer values and that the expected unit (e.g., GB vs GiB) is still clear and correctly interpreted.
- If other VM flavor definitions exist in this repo, consider aligning their `memory` value types (all int or all float/strings) to avoid subtle parsing or validation inconsistencies across different environments.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Adjust the OpenShift VM flavor configuration to use 1.5 units of memory instead of 2.