Skip to content

Change memory to 1.5 for openshift vm.#701

Merged
libhe merged 1 commit intovirt-s1:masterfrom
libhe:master
Mar 27, 2026
Merged

Change memory to 1.5 for openshift vm.#701
libhe merged 1 commit intovirt-s1:masterfrom
libhe:master

Conversation

@libhe
Copy link
Copy Markdown
Collaborator

@libhe libhe commented Mar 27, 2026

Summary by Sourcery

Adjust the OpenShift VM flavor configuration to use 1.5 units of memory instead of 2.

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Mar 27, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adjusts the OpenShift VM configuration to use 1.5 units of memory instead of 2 for the 'small' flavor.

File-Level Changes

Change Details Files
Update the OpenShift 'small' flavor VM memory allocation from 2 to 1.5.
  • Change the VM flavor memory value from 2 to 1.5 in the OpenShift YAML configuration under the 'Flavor' section
  • Keep all other VM flavor attributes (cpu, size, virt) unchanged
os_tests/cfg/openshift.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The memory field was changed from an integer to a float; double-check that all consumers of this config support non-integer values and that the expected unit (e.g., GB vs GiB) is still clear and correctly interpreted.
  • If other VM flavor definitions exist in this repo, consider aligning their memory value types (all int or all float/strings) to avoid subtle parsing or validation inconsistencies across different environments.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The `memory` field was changed from an integer to a float; double-check that all consumers of this config support non-integer values and that the expected unit (e.g., GB vs GiB) is still clear and correctly interpreted.
- If other VM flavor definitions exist in this repo, consider aligning their `memory` value types (all int or all float/strings) to avoid subtle parsing or validation inconsistencies across different environments.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@libhe libhe marked this pull request as draft March 27, 2026 06:32
@libhe libhe marked this pull request as ready for review March 27, 2026 06:32
@libhe libhe merged commit f77a82d into virt-s1:master Mar 27, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant