dynamic white list; tcp-udp config switch

[nevinitsin]

Hi!

I added tcp/udp proto in config and made whitelist work like blacklist: renew from urls
https://letsencrypt.org/ + stunnel + tcp go-hole works fine for android's 'private dns' feature

[virtualzone]

Hi @nevinitsin ,

thanks for your contribution!

I think two things got mixed up here:

• The blacklist sources are really URL sources of blacklists, so the URLs are loaded and the records provided are added to the list.
• The whitelist (no "sources" here :-) ) is a static whitelist defined in the config.

As far as I can see, you turned the static whitelist into a dynamic URL source, just like the blacklist. While I appreciate the underlying idea, I think this should be implemented in cleaner way:

• Keep the static whitelist as it is as your change would break existing configs
• Add a new Config property "WhitelistSources" which does what you intended to implement

Wdyt?

[nevinitsin]

Thank you for prompt reply!
I think you are right, I'll rewrite PR to keep static whitelist and add a new option