Skip to content

SDK version and SDK platform parameters to VirtusizeParams #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ObranS merged 11 commits into from
Nov 17, 2025
Merged

SDK version and SDK platform parameters to VirtusizeParams #195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
4406f60
- Feature: SDK version and SDK platform parameters added (NSDK-316)
ObranS Sep 19, 2025
35585c5
Merge branch 'trunk' into feature/NSDK-316-sdk-parameters
ObranS Sep 27, 2025
38d71d8
Update APIEventTests.swift
ObranS Sep 27, 2025
00fae02
Merge branch 'trunk' into feature/NSDK-316-sdk-parameters
Sep 28, 2025
9c1e37c
Merge branch 'trunk' into feature/NSDK-316-sdk-parameters
Oct 23, 2025
3e07e9d
Merge branch 'trunk' into feature/NSDK-316-sdk-parameters
Nov 13, 2025
16fd17f
- Fix: CI unit-tests run fails due to simulator version unavailable
Nov 14, 2025
d0393e2
Change CI runs-on version
Nov 17, 2025
5a90e7f
Update CI destination device model
Nov 17, 2025
6e648af
revert build platform
Nov 17, 2025
a83326b
Merge branch 'trunk' into feature/NSDK-316-sdk-parameters
Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/pull-request-checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
run: pod lib lint --include-podspecs="Virtusize*.podspec" --allow-warnings

test:
runs-on: macos-15
runs-on: macos-26
steps:
- name: Check out code
uses: actions/checkout@v4
Expand Down
4 changes: 2 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ virtusize-test:
-workspace "Virtusize.xcworkspace" \
-scheme "VirtusizeTests" \
-sdk "iphonesimulator" \
-destination "platform=iOS Simulator,name=iPhone SE (3rd generation),OS=latest"
-destination "platform=iOS Simulator,name=iPhone 16e,OS=18.6"

virtusize-core-test:

Expand All @@ -45,7 +45,7 @@ virtusize-core-test:
-workspace "Virtusize.xcworkspace" \
-scheme "VirtusizeCoreTests" \
-sdk "iphonesimulator" \
-destination "platform=iOS Simulator,name=iPhone SE (3rd generation),OS=latest" \
-destination "platform=iOS Simulator,name=iPhone 16e,OS=18.6" \
-parallel-testing-enabled NO

test: virtusize-test virtusize-core-test
Expand Down
2 changes: 2 additions & 0 deletions Virtusize.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -929,6 +929,7 @@
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
CODE_SIGN_IDENTITY = "iPhone Developer";
COPY_PHASE_STRIP = NO;
CURRENT_PROJECT_VERSION = 2.12.14;
CURRENT_PROJECT_VERSION = 2.12.15;
DEBUG_INFORMATION_FORMAT = dwarf;
ENABLE_STRICT_OBJC_MSGSEND = YES;
Expand Down Expand Up @@ -999,6 +1000,7 @@
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
CODE_SIGN_IDENTITY = "iPhone Developer";
COPY_PHASE_STRIP = NO;
CURRENT_PROJECT_VERSION = 2.12.14;
CURRENT_PROJECT_VERSION = 2.12.15;
DEBUG_INFORMATION_FORMAT = "dwarf-with-dsym";
ENABLE_NS_ASSERTIONS = NO;
Expand Down
4 changes: 4 additions & 0 deletions Virtusize/Sources/Models/VirtusizeParams.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,8 @@ public class VirtusizeParams {
paramsScript += "\(ParamKey.detailsPanelCards): \(detailsPanelCards.map { category in category.rawValue }), "
paramsScript += "\(ParamKey.language): '\(language.rawValue)', "
paramsScript += "\(ParamKey.region): '\(region.rawValue)', "
paramsScript += "\(ParamKey.sdkVersion): '\(VirtusizeConfiguration.SDKVersion)', "
paramsScript += "\(ParamKey.sdkPlatform): 'ios', "
paramsScript += "\(ParamKey.environment): '\(Virtusize.environment.isProdEnv ? "production" : "staging")'})"
return paramsScript
}
Expand Down Expand Up @@ -123,5 +125,7 @@ public class VirtusizeParams {
static let showSGI = "showSGI"
static let allowedLanguages = "allowedLanguages"
static let detailsPanelCards = "detailsPanelCards"
static let sdkVersion = "sdkVersion"
static let sdkPlatform = "sdkPlatform"
Copy link

@devAbhimanyu devAbhimanyu Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where is this being used?

Copy link
Contributor Author

@ObranS ObranS Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://app.clickup.com/t/3702259/NSDK-315

"sdkVersion": "1.2.3",
"sdkPlatform": "ios"

These parameters are injected into the WebUI. See VirtusizeWebViewController, line 290.

Afterwards, these parameters are represented in the WebView. They are used in the Flutter version to determine whether the platform is iOS or Android for diagnostic purposes.

}
}
2 changes: 2 additions & 0 deletions VirtusizeAuth/VirtusizeAuth.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,6 +389,7 @@
CLANG_WARN_UNREACHABLE_CODE = YES;
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
COPY_PHASE_STRIP = NO;
CURRENT_PROJECT_VERSION = 2.12.14;
CURRENT_PROJECT_VERSION = 2.12.15;
DEBUG_INFORMATION_FORMAT = dwarf;
ENABLE_STRICT_OBJC_MSGSEND = YES;
Expand Down Expand Up @@ -455,6 +456,7 @@
CLANG_WARN_UNREACHABLE_CODE = YES;
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
COPY_PHASE_STRIP = NO;
CURRENT_PROJECT_VERSION = 2.12.14;
CURRENT_PROJECT_VERSION = 2.12.15;
DEBUG_INFORMATION_FORMAT = "dwarf-with-dsym";
ENABLE_NS_ASSERTIONS = NO;
Expand Down
2 changes: 2 additions & 0 deletions VirtusizeCore/VirtusizeCore.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -495,6 +495,7 @@
CLANG_WARN_UNREACHABLE_CODE = YES;
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
COPY_PHASE_STRIP = NO;
CURRENT_PROJECT_VERSION = 2.12.14;
CURRENT_PROJECT_VERSION = 2.12.15;
DEBUG_INFORMATION_FORMAT = dwarf;
ENABLE_STRICT_OBJC_MSGSEND = YES;
Expand Down Expand Up @@ -560,6 +561,7 @@
CLANG_WARN_UNREACHABLE_CODE = YES;
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
COPY_PHASE_STRIP = NO;
CURRENT_PROJECT_VERSION = 2.12.14;
CURRENT_PROJECT_VERSION = 2.12.15;
DEBUG_INFORMATION_FORMAT = "dwarf-with-dsym";
ENABLE_NS_ASSERTIONS = NO;
Expand Down