Skip to content

NSDK-355 Fixed recommended size request parameter #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ObranS merged 2 commits into from
Dec 4, 2025
Merged

NSDK-355 Fixed recommended size request parameter #208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e899545
Bugfix: Fixed recommended size request parameter
Dec 4, 2025
1fc6299
Fix unit tests issues
Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions Virtusize/Sources/Internal/Models/VirtusizeGetSizeParams.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ internal struct VirtusizeGetSizeParams: Codable {
userBodyProfile: VirtusizeUserBodyProfile?

) {
let additionalInfo = [
var additionalInfo: [String: VirtusizeAnyCodable] = [
"brand": VirtusizeAnyCodable(
storeProduct.storeProductMeta?.additionalInfo?.brand ?? storeProduct.storeProductMeta?.brand ?? ""
),
Expand All @@ -63,14 +63,17 @@ internal struct VirtusizeGetSizeParams: Codable {
"sizes": VirtusizeAnyCodable(
storeProduct.storeProductMeta?.additionalInfo?.sizes ?? [:]
),
"modelInfo": VirtusizeAnyCodable(getModelInfoDict(storeProduct: storeProduct)),
"gender": VirtusizeAnyCodable(
storeProduct.storeProductMeta?.additionalInfo?.gender ?? "male"
),
"style": VirtusizeAnyCodable(
storeProduct.storeProductMeta?.additionalInfo?.style ?? "regular"
),
)
]

if let modelInfo = getModelInfoDict(storeProduct: storeProduct) {
additionalInfo["modelInfo"] = VirtusizeAnyCodable(modelInfo)
}
bodyData = getBodyDataDict(userBodyProfile: userBodyProfile)
let itemSizesOrig = getItemSizesDict(storeProduct: storeProduct)
var productType = ""
Expand Down
4 changes: 2 additions & 2 deletions Virtusize/Sources/Models/VirtusizeEnvironment.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,9 @@ public enum VirtusizeEnvironment: String, CaseIterable {
internal func getSizeUrl() -> String {
switch self {
case .TESTING:
return "size-recommendation.virtusize.jp"
return "size-recommendation.staging.virtusize.jp"
case .STAGING:
return "size-recommendation.virtusize.com"
return "size-recommendation.staging.virtusize.jp"
case .GLOBAL:
return "size-recommendation.virtusize.com"
case .JAPAN:
Expand Down
2 changes: 1 addition & 1 deletion Virtusize/Tests/APIEndpointsTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ class APIEndpointsTests: XCTestCase {
func testGetSizeEndpoint_returnExpectedComponents() {
let endpoint = APIEndpoints.getItemSizeRecommendation

XCTAssertEqual(endpoint.components.host, "size-recommendation.virtusize.com")
XCTAssertEqual(endpoint.components.host, "size-recommendation.staging.virtusize.jp")
XCTAssertEqual(endpoint.components.path, "/item")

XCTAssertNil(endpoint.components.queryItems)
Expand Down
2 changes: 1 addition & 1 deletion Virtusize/Tests/APIRequestTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ class APIRequestTests: XCTestCase {
XCTAssertEqual(actualParams?.items.first?.productType, "jacket")
XCTAssertEqual(
apiRequest?.url?.absoluteString,
"https://size-recommendation.virtusize.com/item"
"https://size-recommendation.staging.virtusize.jp/item"
)
}
}
1 change: 0 additions & 1 deletion Virtusize/Tests/VirtusizeGetSizeParamsTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,6 @@ class VirtusizeGetSizeParamsTests: XCTestCase {
"brand": "",
"fit": "regular",
"sizes": {},
"modelInfo": null,
"gender": "null",
"style": "fashionable"
},
Expand Down