Skip to content

NSDK-355 VirtusizeWebView redirect url for FAQ page #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ObranS merged 1 commit into from
Dec 8, 2025
Merged

NSDK-355 VirtusizeWebView redirect url for FAQ page #209

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@ Use list notation, and following prefixes:
- Bugfix - when fixing any major bug
- Docs - for any improvement to documentation


### Changes
- Bugfix: VirtusizeWebView redirect url for FAQ page

### 2.12.18
- Fix: Recommended size for VirtusizeButton
- Fix: Migrate product types implementation locally
Expand Down
5 changes: 4 additions & 1 deletion Virtusize/Sources/UI/VirtusizeWebViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,15 +354,18 @@ extension VirtusizeWebViewController: WKNavigationDelegate, WKUIDelegate {
popupWebView = WKWebView(frame: self.view.frame, configuration: configuration)
popupWebView!.navigationDelegate = self
popupWebView!.uiDelegate = self

self.view.addSubview(popupWebView!)
return popupWebView
}

return nil
}

/// Checks if a URL is an external link to be open on the Safari browser
private func isExternalLinks(url: String?) -> Bool {
return url != nil && (url!.contains("survey") || url!.contains("privacy"))
return url != nil && (url!.contains("survey") || url!.contains("privacy") || url!.contains("notion") ||
url!.contains("surveymonkey"))
}

public func webViewDidClose(_ webView: WKWebView) {
Expand Down