Skip to content

test(rsc): unskip react-router canary #710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

test(rsc): unskip react-router canary #710

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/plugin-rsc/e2e/react-router.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
import { createHash } from 'node:crypto'
import { expect, test } from '@playwright/test'
import { type Fixture, useFixture } from './fixture'
import { expectNoReload, testNoJs, waitForHydration } from './helper'
import { readFileSync } from 'node:fs'
import React from 'react'
// import React from 'react'

test.describe('dev-default', () => {
test.skip(/canary|experimental/.test(React.version))
// test.skip(/canary|experimental/.test(React.version))

const f = useFixture({ root: 'examples/react-router', mode: 'dev' })
defineTest(f)
Expand All @@ -18,7 +18,7 @@
})

test.describe('dev-cloudflare', () => {
test.skip(/canary|experimental/.test(React.version))
// test.skip(/canary|experimental/.test(React.version))

const f = useFixture({
root: 'examples/react-router',
Expand All @@ -40,7 +40,7 @@

function defineTest(f: Fixture) {
test('loader', async ({ page }) => {
await page.goto(f.url())

Check failure on line 43 in packages/plugin-rsc/e2e/react-router.test.ts

View workflow job for this annotation

GitHub Actions / test-rsc (ubuntu-latest / chromium) (react-canary)

[chromium] › e2e/react-router.test.ts:42:3 › dev-default › loader 

  1) [chromium] › e2e/react-router.test.ts:42:3 › dev-default › loader ─────────────────────────────

    Retry #2 ───────────────────────────────────────────────────────────────────────────────────────
    Error: page.goto: net::ERR_ABORTED; maybe frame was detached?
    Call log:
      - navigating to "http://localhost:5173/", waiting until "load"


      41 | function defineTest(f: Fixture) {
      42 |   test('loader', async ({ page }) => {
    > 43 |     await page.goto(f.url())
         |                ^
      44 |     await expect(page.getByText(`loaderData: {"name":"Unknown"}`)).toBeVisible()
      45 |   })
      46 |
        at /home/runner/work/vite-plugin-react/vite-plugin-react/packages/plugin-rsc/e2e/react-router.test.ts:43:16

Check failure on line 43 in packages/plugin-rsc/e2e/react-router.test.ts

View workflow job for this annotation

GitHub Actions / test-rsc (ubuntu-latest / chromium) (react-canary)

[chromium] › e2e/react-router.test.ts:42:3 › dev-default › loader 

  1) [chromium] › e2e/react-router.test.ts:42:3 › dev-default › loader ─────────────────────────────

    Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
    Error: page.goto: net::ERR_ABORTED; maybe frame was detached?
    Call log:
      - navigating to "http://localhost:5174/", waiting until "load"


      41 | function defineTest(f: Fixture) {
      42 |   test('loader', async ({ page }) => {
    > 43 |     await page.goto(f.url())
         |                ^
      44 |     await expect(page.getByText(`loaderData: {"name":"Unknown"}`)).toBeVisible()
      45 |   })
      46 |
        at /home/runner/work/vite-plugin-react/vite-plugin-react/packages/plugin-rsc/e2e/react-router.test.ts:43:16

Check failure on line 43 in packages/plugin-rsc/e2e/react-router.test.ts

View workflow job for this annotation

GitHub Actions / test-rsc (ubuntu-latest / chromium) (react-canary)

[chromium] › e2e/react-router.test.ts:42:3 › dev-default › loader 

  1) [chromium] › e2e/react-router.test.ts:42:3 › dev-default › loader ─────────────────────────────
    Error: page.goto: net::ERR_ABORTED; maybe frame was detached?
    Call log:
      - navigating to "http://localhost:5173/", waiting until "load"


      41 | function defineTest(f: Fixture) {
      42 |   test('loader', async ({ page }) => {
    > 43 |     await page.goto(f.url())
         |                ^
      44 |     await expect(page.getByText(`loaderData: {"name":"Unknown"}`)).toBeVisible()
      45 |   })
      46 |
        at /home/runner/work/vite-plugin-react/vite-plugin-react/packages/plugin-rsc/e2e/react-router.test.ts:43:16

Check failure on line 43 in packages/plugin-rsc/e2e/react-router.test.ts

View workflow job for this annotation

GitHub Actions / test-rsc (ubuntu-latest / chromium) (react-experimental)

[chromium] › e2e/react-router.test.ts:42:3 › dev-default › loader 

  1) [chromium] › e2e/react-router.test.ts:42:3 › dev-default › loader ─────────────────────────────

    Retry #2 ───────────────────────────────────────────────────────────────────────────────────────
    Error: page.goto: net::ERR_ABORTED; maybe frame was detached?
    Call log:
      - navigating to "http://localhost:5173/", waiting until "load"


      41 | function defineTest(f: Fixture) {
      42 |   test('loader', async ({ page }) => {
    > 43 |     await page.goto(f.url())
         |                ^
      44 |     await expect(page.getByText(`loaderData: {"name":"Unknown"}`)).toBeVisible()
      45 |   })
      46 |
        at /home/runner/work/vite-plugin-react/vite-plugin-react/packages/plugin-rsc/e2e/react-router.test.ts:43:16

Check failure on line 43 in packages/plugin-rsc/e2e/react-router.test.ts

View workflow job for this annotation

GitHub Actions / test-rsc (ubuntu-latest / chromium) (react-experimental)

[chromium] › e2e/react-router.test.ts:42:3 › dev-default › loader 

  1) [chromium] › e2e/react-router.test.ts:42:3 › dev-default › loader ─────────────────────────────

    Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
    Error: page.goto: net::ERR_ABORTED; maybe frame was detached?
    Call log:
      - navigating to "http://localhost:5173/", waiting until "load"


      41 | function defineTest(f: Fixture) {
      42 |   test('loader', async ({ page }) => {
    > 43 |     await page.goto(f.url())
         |                ^
      44 |     await expect(page.getByText(`loaderData: {"name":"Unknown"}`)).toBeVisible()
      45 |   })
      46 |
        at /home/runner/work/vite-plugin-react/vite-plugin-react/packages/plugin-rsc/e2e/react-router.test.ts:43:16

Check failure on line 43 in packages/plugin-rsc/e2e/react-router.test.ts

View workflow job for this annotation

GitHub Actions / test-rsc (ubuntu-latest / chromium) (react-experimental)

[chromium] › e2e/react-router.test.ts:42:3 › dev-default › loader 

  1) [chromium] › e2e/react-router.test.ts:42:3 › dev-default › loader ─────────────────────────────
    Error: page.goto: net::ERR_ABORTED; maybe frame was detached?
    Call log:
      - navigating to "http://localhost:5173/", waiting until "load"


      41 | function defineTest(f: Fixture) {
      42 |   test('loader', async ({ page }) => {
    > 43 |     await page.goto(f.url())
         |                ^
      44 |     await expect(page.getByText(`loaderData: {"name":"Unknown"}`)).toBeVisible()
      45 |   })
      46 |
        at /home/runner/work/vite-plugin-react/vite-plugin-react/packages/plugin-rsc/e2e/react-router.test.ts:43:16
await expect(page.getByText(`loaderData: {"name":"Unknown"}`)).toBeVisible()
})

Expand All @@ -54,7 +54,7 @@
})

test('navigation', async ({ page }) => {
await page.goto(f.url())

Check failure on line 57 in packages/plugin-rsc/e2e/react-router.test.ts

View workflow job for this annotation

GitHub Actions / test-rsc (ubuntu-latest / chromium) (react-canary)

[chromium] › e2e/react-router.test.ts:56:3 › dev-default › navigation 

  2) [chromium] › e2e/react-router.test.ts:56:3 › dev-default › navigation ─────────────────────────

    Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
    Error: page.goto: net::ERR_ABORTED; maybe frame was detached?
    Call log:
      - navigating to "http://localhost:5173/", waiting until "load"


      55 |
      56 |   test('navigation', async ({ page }) => {
    > 57 |     await page.goto(f.url())
         |                ^
      58 |     await waitForHydration(page)
      59 |     await using _ = await expectNoReload(page)
      60 |
        at /home/runner/work/vite-plugin-react/vite-plugin-react/packages/plugin-rsc/e2e/react-router.test.ts:57:16

Check failure on line 57 in packages/plugin-rsc/e2e/react-router.test.ts

View workflow job for this annotation

GitHub Actions / test-rsc (ubuntu-latest / chromium) (react-canary)

[chromium] › e2e/react-router.test.ts:56:3 › dev-default › navigation 

  2) [chromium] › e2e/react-router.test.ts:56:3 › dev-default › navigation ─────────────────────────
    Error: page.goto: net::ERR_ABORTED; maybe frame was detached?
    Call log:
      - navigating to "http://localhost:5173/", waiting until "load"


      55 |
      56 |   test('navigation', async ({ page }) => {
    > 57 |     await page.goto(f.url())
         |                ^
      58 |     await waitForHydration(page)
      59 |     await using _ = await expectNoReload(page)
      60 |
        at /home/runner/work/vite-plugin-react/vite-plugin-react/packages/plugin-rsc/e2e/react-router.test.ts:57:16

Check failure on line 57 in packages/plugin-rsc/e2e/react-router.test.ts

View workflow job for this annotation

GitHub Actions / test-rsc (ubuntu-latest / chromium) (react-experimental)

[chromium] › e2e/react-router.test.ts:56:3 › dev-default › navigation 

  2) [chromium] › e2e/react-router.test.ts:56:3 › dev-default › navigation ─────────────────────────

    Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
    Error: page.goto: net::ERR_ABORTED; maybe frame was detached?
    Call log:
      - navigating to "http://localhost:5173/", waiting until "load"


      55 |
      56 |   test('navigation', async ({ page }) => {
    > 57 |     await page.goto(f.url())
         |                ^
      58 |     await waitForHydration(page)
      59 |     await using _ = await expectNoReload(page)
      60 |
        at /home/runner/work/vite-plugin-react/vite-plugin-react/packages/plugin-rsc/e2e/react-router.test.ts:57:16

Check failure on line 57 in packages/plugin-rsc/e2e/react-router.test.ts

View workflow job for this annotation

GitHub Actions / test-rsc (ubuntu-latest / chromium) (react-experimental)

[chromium] › e2e/react-router.test.ts:56:3 › dev-default › navigation 

  2) [chromium] › e2e/react-router.test.ts:56:3 › dev-default › navigation ─────────────────────────
    Error: page.goto: net::ERR_ABORTED; maybe frame was detached?
    Call log:
      - navigating to "http://localhost:5173/", waiting until "load"


      55 |
      56 |   test('navigation', async ({ page }) => {
    > 57 |     await page.goto(f.url())
         |                ^
      58 |     await waitForHydration(page)
      59 |     await using _ = await expectNoReload(page)
      60 |
        at /home/runner/work/vite-plugin-react/vite-plugin-react/packages/plugin-rsc/e2e/react-router.test.ts:57:16
await waitForHydration(page)
await using _ = await expectNoReload(page)

Expand Down
Loading