Skip to content

refactor!: remove experimental.skipSsrTransform option #20038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

refactor!: remove experimental.skipSsrTransform option #20038

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b4d4c32
refactor!: remove `experimental.skipSsrTransform` option
sapphi-red May 14, 2025
c3cf041
chore: add back a comment
sapphi-red May 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 1 addition & 17 deletions packages/vite/src/node/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -501,14 +501,6 @@ export interface ExperimentalOptions {
* @default false
*/
hmrPartialAccept?: boolean
/**
* Skips SSR transform to make it easier to use Vite with Node ESM loaders.
* @warning Enabling this will break normal operation of Vite's SSR in development mode.
*
* @experimental
* @default false
*/
skipSsrTransform?: boolean
}

export interface LegacyOptions {
Expand Down Expand Up @@ -695,7 +687,6 @@ export const configDefaults = Object.freeze({
importGlobRestoreExtension: false,
renderBuiltUrl: undefined,
hmrPartialAccept: false,
skipSsrTransform: false,
},
future: {
removePluginHookHandleHotUpdate: undefined,
Expand Down Expand Up @@ -745,7 +736,6 @@ export function resolveDevEnvironmentOptions(
environmentName: string | undefined,
consumer: 'client' | 'server' | undefined,
// Backward compatibility
skipSsrTransform?: boolean,
preTransformRequest?: boolean,
): ResolvedDevEnvironmentOptions {
const resolved = mergeWithDefaults(
Expand All @@ -758,10 +748,7 @@ export function resolveDevEnvironmentOptions(
? defaultCreateClientDevEnvironment
: defaultCreateDevEnvironment,
recoverable: consumer === 'client',
moduleRunnerTransform:
skipSsrTransform !== undefined && consumer === 'server'
? skipSsrTransform
: consumer === 'server',
moduleRunnerTransform: consumer === 'server',
},
dev ?? {},
)
Expand All @@ -782,7 +769,6 @@ function resolveEnvironmentOptions(
logger: Logger,
environmentName: string,
// Backward compatibility
skipSsrTransform?: boolean,
isSsrTargetWebworkerSet?: boolean,
preTransformRequests?: boolean,
): ResolvedEnvironmentOptions {
Expand Down Expand Up @@ -837,7 +823,6 @@ function resolveEnvironmentOptions(
options.dev,
environmentName,
consumer,
skipSsrTransform,
preTransformRequests,
),
build: resolveBuildEnvironmentOptions(
Expand Down Expand Up @@ -1244,7 +1229,6 @@ export async function resolveConfig(
inlineConfig.forceOptimizeDeps,
logger,
environmentName,
config.experimental?.skipSsrTransform,
config.ssr?.target === 'webworker',
config.server?.preTransformRequests,
)
Expand Down