fix: treat all optimizeDeps.entries
values as globs
#20045
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes an issue introduced in #15853 that meant globs containing
\\
could be treated as literals rather than globs. This would then lead the filesystem check here -vite/packages/vite/src/node/optimizer/scan.ts
Line 281 in 8679a43
\
. It also improves upon the previous approach because entries explicitly includingnode_modules
can now be used alongside other glob entries.These changes mean that explicitly passing entries containing the environment's build output directory no longer work. It's not clear why this feature was introduced but if it would be considered breaking to remove it then I can add in the extra handling.