Trailing whitespace added to text of elements with namespaces#5
Open
bbpennel wants to merge 2 commits intovkiryukhin:masterfrom
Open
Trailing whitespace added to text of elements with namespaces#5bbpennel wants to merge 2 commits intovkiryukhin:masterfrom
bbpennel wants to merge 2 commits intovkiryukhin:masterfrom
Conversation
|
good job, thx a lot! 👍 |
|
Good job! 👍 |
|
Is this fix supposed to be approved? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An issue I'm having is that when a tag contains a namespace it causes the closing tag of the element to drop to a new line and indent, which adds additional whitespace into the text.
Produces:
This pull request prevents that newline and indent from being added to elements when they have namespaces.
Indentation should still be working correctly for elements nested in elements with namespaces.
Produces:
And thanks for making this great tool!