More rigorous checking of optional arguments#5
Open
stt wants to merge 1 commit intovkiryukhin:masterfrom
Open
Conversation
I.e. allow context to be an array.
Owner
|
Hi stt, Good catch!
I haven't work on this plugin for a while. If would useful if you provide most simple and most complex examples of object which you use for testing. Thank you for working on plugin's improvement. --Vadim |
Author
|
This was probably meant as comment to #6 but only option for try-catch I see now is to do the "[native code]" string checking before calling or evaling it in JSONfn, either way it would duplicate couple of checks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was looking to do array filtering in a webworker and noticed that context was not set correctly as it though it was a list of imports.
By the way, although retrospectively obvious, it might be worth noting somewhere clearly that native functions can't be serialized by JSONfn. 😄
(I used the polyfill from https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Global_Objects/Array/filter)