Make space after 'Floor N|Nth Floor' optional#27
Open
thedansimonson wants to merge 5 commits intovladimarius:masterfrom
Open
Make space after 'Floor N|Nth Floor' optional#27thedansimonson wants to merge 5 commits intovladimarius:masterfrom
thedansimonson wants to merge 5 commits intovladimarius:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The "floor" regular expression in all three regex data modules was specified such that a space trailing the floor component of an address string was mandatory. This means that an address like:
would fail to parse; however, the following would succeed:
I suspect the trailing space was there in analogy with the occupancy regular expression where there are trailing spaces after Suite/Apartment/Room. The trailing space there is actually mandatory, since it separates the occupancy type from the number.
In the case of floor, the number is part of the floor expression, so the space is optional and arguably superfluous, though spaces between floor number and a comma afterward may crop up from time-to-time and wouldn't necessarily inhibit something from being an address.
Changes