-
Notifications
You must be signed in to change notification settings - Fork 39
[WIP] fix qparams decompression #514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
dsikka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just an fyi: #509
This will also impact mxfp4.
I've turned off mxfp4 decompression in the meantime / lower priority anyway
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be cleaner to add optional:
compress_scale / decompress_scale
and compress_zp / decompress_zp functions?
This would impact:
- PackedCompressor (packed zp)
- NVFP4PackedCompressor (fp8 scales)
- MXFP4PackedCompressor (uint8 scales)
Sure! I can do that. |
Signed-off-by: shanjiaz <zsjwpianpian@gmail.com>
Updated the
decompress_weightfunction to unpack zero_point/cast scale dtype during decompression. Replace the tensor in module with updated one.Example script now generates coherent result: