[GuideLLM Refactor] Multi-Turn Rework #374
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjmonson
commented
Sep 26, 2025
Comment on lines
+85
to
+99
| @SchedulerMessagingPydanticRegistry.register() | ||
| class ScheduledRequestAugmentation(StandardBaseModel): | ||
| """ | ||
| Adjustments to scheduler logic for a paired request. | ||
| """ | ||
|
|
||
| post_requeue_delay: float = Field( | ||
| description=( | ||
| "Delay in seconds to wait after a request to " | ||
| "queue the next request in the conversation." | ||
| ), | ||
| default=0.0, | ||
| ) | ||
|
|
||
|
|
There was a problem hiding this comment.
This could be a part of ScheduledRequestInfo but I figured it was not really necessary to pass it back and forth with each request update. Plus I thought this would be a good interface for adjusting the scheduling of individual requests.
sjmonson
commented
Sep 26, 2025
Comment on lines
+502
to
+517
| def _apply_history( | ||
| self, | ||
| request: GenerationRequest, | ||
| history: HistoryT[GenerationRequest, GenerationResponse], | ||
| ) -> GenerationRequest: | ||
| """ | ||
| Apply conversation history to the current request. | ||
| """ | ||
|
|
||
| def turn_to_text(turn: tuple[GenerationRequest, GenerationResponse]) -> str: | ||
| req, res = turn | ||
| return f"{req.content}{res.value}" | ||
|
|
||
| request.content = "".join(chain(map(turn_to_text, history), (request.content,))) | ||
| return request | ||
|
|
There was a problem hiding this comment.
Temporary hack until we land request templates.
sjmonson
force-pushed
the
features/refactor/base-draft
branch
from
4c4ea5d to
aa81de8
Compare
## Summary <!-- Include a short paragraph of the changes introduced in this PR. If this PR requires additional context or rationale, explain why the changes are necessary. --> ## Details <!-- Provide a detailed list of all changes introduced in this pull request. --> - [ ] ## Test Plan <!-- List the steps needed to test this PR. --> - ## Related Issues <!-- Link any relevant issues that this PR addresses. --> - Resolves # --- - [x] "I certify that all code in this PR is my own, except as noted below." ## Use of AI - [ ] Includes AI-assisted code completion - [ ] Includes code generated by an AI application - [ ] Includes AI-generated tests (NOTE: AI written tests should have a docstring that includes `## WRITTEN BY AI ##`)
Signed-off-by: Samuel Monson <smonson@redhat.com>
Signed-off-by: Samuel Monson <smonson@redhat.com>
Signed-off-by: Samuel Monson <smonson@redhat.com>
Signed-off-by: Samuel Monson <smonson@redhat.com>
Signed-off-by: Samuel Monson <smonson@redhat.com>
Signed-off-by: Samuel Monson <smonson@redhat.com>
Signed-off-by: Samuel Monson <smonson@redhat.com>
Signed-off-by: Samuel Monson <smonson@redhat.com>
Signed-off-by: Samuel Monson <smonson@redhat.com>
Signed-off-by: Samuel Monson <smonson@redhat.com>
sjmonson
force-pushed
the
features/refactor/multiturn
branch
from
9ae0532 to
cd43b2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Details
Test Plan
Related Issues
Use of AI
## WRITTEN BY AI ##)