Skip to content

Conversation

tao12345666333
Copy link
Contributor

What type of PR is this?

feat: Support generic categories and MMLR-Pro mapping

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #119

Release Notes: Yes/No

Copy link

netlify bot commented Sep 22, 2025

Deploy Preview for vllm-semantic-router ready!

Name Link
🔨 Latest commit 1db99d4
🔍 Latest deploy log https://app.netlify.com/projects/vllm-semantic-router/deploys/68d26fe451cd36000832bde8
😎 Deploy Preview https://deploy-preview-192--vllm-semantic-router.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

github-actions bot commented Sep 22, 2025

👥 vLLM Semantic Team Notification

The following members have been identified for the changed files in this PR and have been automatically assigned:

📁 config

Owners: @rootfs
Files changed:

  • config/examples/generic_categories.yaml

📁 src

Owners: @rootfs, @Xunzhuo, @wangchen615
Files changed:

  • src/semantic-router/pkg/config/mmlu_categories_test.go
  • src/semantic-router/pkg/utils/classification/generic_category_mapping_test.go
  • src/semantic-router/pkg/config/config.go
  • src/semantic-router/pkg/utils/classification/classifier.go
  • src/semantic-router/pkg/utils/classification/model_discovery_test.go

📁 website

Owners: @Xunzhuo
Files changed:

  • website/docs/api/classification.md

vLLM

🎉 Thanks for your contributions!

This comment was automatically generated based on the OWNER files in the repository.

rootfs
rootfs previously approved these changes Sep 22, 2025
@rootfs
Copy link
Collaborator

rootfs commented Sep 22, 2025

@Xunzhuo @yuluo-yx PTAL, thanks.

Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
rootfs
rootfs previously approved these changes Sep 22, 2025
@Xunzhuo
Copy link
Member

Xunzhuo commented Sep 22, 2025

/hold for a while, will review tomorrow

@github-actions github-actions bot added the hold label Sep 22, 2025
Copy link
Contributor

@yuluo-yx yuluo-yx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, has left some comments. pls take a look.

Copy link
Member

@Xunzhuo Xunzhuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code overall looks good to me, plz add UT around this feature

Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
@Xunzhuo
Copy link
Member

Xunzhuo commented Sep 23, 2025

/lgtm
Thanks

@github-actions github-actions bot added the lgtm label Sep 23, 2025
@Xunzhuo Xunzhuo merged commit 7a0221b into vllm-project:main Sep 23, 2025
9 checks passed
@tao12345666333 tao12345666333 deleted the feat-mmlu-pro-mapping branch September 23, 2025 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support generic categories and map to MMLU-Pro
5 participants