Skip to content

Conversation

@JiriesKaileh
Copy link
Collaborator

Description

Removing problematic local path that causes CI to error. Changed to path that is compatible with CI environment

Signed-off-by: JiriesKaileh <jiries@google.com>
@github-actions
Copy link

Description

Start with a short description of what the PR does and how this is a change from
the past.

The rest of the description includes relevant details and context, examples:

  • why is this change being made,
  • the problem being solved and any relevant context,
  • why this is a good solution,
  • some information about the specific implementation,
  • shortcomings of the solution and possible future improvements.

If the change fixes a bug or a Github issue, please include a link, e.g.,:
FIXES: b/123456
FIXES: #123456

Tests

Please describe how you tested this change, and include any instructions and/or
commands to reproduce.

Checklist

Before submitting this PR, please make sure:

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have made or will make corresponding changes to any relevant documentation.

run_accuracy_check() {
echo -e "\n--- Running Accuracy Check (Mode: ACCURACY) ---"

CONFTEST_DIR="/workspace/tpu-inference/scripts/vllm/integration"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a typo in this path: should be tpu_inference (underscore instead of hyphen). Otherwise, it will be an invalid path (link).

The integration test still fails with the above fix though: link

Signed-off-by: JiriesKaileh <jiries@google.com>
Signed-off-by: JiriesKaileh <jiries@google.com>
Signed-off-by: JiriesKaileh <jiries@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants