Skip to content

[Doc]: Fix typo in fused_moe layer #29731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vllm-bot merged 1 commit into from
Nov 30, 2025
Merged

[Doc]: Fix typo in fused_moe layer #29731

vllm-bot merged 1 commit into from
Nov 30, 2025

Conversation

@BowTen
Copy link
Contributor

@BowTen BowTen commented Nov 29, 2025 •
edited by github-actions bot
Loading

Purpose

Fix a typo in vllm/model_executor/layers/fused_moe/layer.py

Test Plan

Test Result

Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

@BowTen
[Doc]: Fix typo in fused_moe layer
a55a05f 
Signed-off-by: BowTen <bowten@qq.com>
@chatgpt-codex-connector
Copy link

chatgpt-codex-connector bot commented Nov 29, 2025

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.

gemini-code-assist[bot]
gemini-code-assist bot reviewed Nov 29, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request corrects a typo in a comment within vllm/model_executor/layers/fused_moe/layer.py. The change is correct and improves code readability. There are no issues to address.

DarkLight1337
DarkLight1337 approved these changes Nov 30, 2025
View reviewed changes
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@vllm-bot vllm-bot merged commit 9381b5c into vllm-project:main Nov 30, 2025
7 checks passed
kitaekatt pushed a commit to kitaekatt/vllm that referenced this pull request Dec 1, 2025
@BowTen @kitaekatt
[Doc]: Fix typo in fused_moe layer (vllm-project#29731)
851cbad 
Signed-off-by: BowTen <bowten@qq.com>
amd-hhashemi pushed a commit to amd-hhashemi/vllm that referenced this pull request Dec 2, 2025
@BowTen @amd-hhashemi
[Doc]: Fix typo in fused_moe layer (vllm-project#29731)
8010d52 
Signed-off-by: BowTen <bowten@qq.com>
Signed-off-by: Hashem Hashemi <hashem.hashemi@amd.com>
charlotte12l pushed a commit to charlotte12l/vllm that referenced this pull request Dec 5, 2025
@BowTen @charlotte12l
[Doc]: Fix typo in fused_moe layer (vllm-project#29731)
7545f07 
Signed-off-by: BowTen <bowten@qq.com>
Signed-off-by: Xingyu Liu <charlotteliu12x@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

@mgoin mgoin Awaiting requested review from mgoin mgoin is a code owner

@pavanimajety pavanimajety Awaiting requested review from pavanimajety pavanimajety is a code owner

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BowTen @DarkLight1337 @vllm-bot