Skip to content

[BUILD] fix url joining behavior when downloading precompiled wheels #29792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Harry-Chen wants to merge 1 commit into from
Closed

[BUILD] fix url joining behavior when downloading precompiled wheels #29792

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -683,7 +683,7 @@ def _fetch_metadata_for_variant(

arch = platform.machine()
# try to fetch the wheel metadata from the nightly wheel repo
main_variant = envs.VLLM_MAIN_CUDA_VERSION.replace(".", "")
main_variant = "cu" + envs.VLLM_MAIN_CUDA_VERSION.replace(".", "")
variant = os.getenv("VLLM_PRECOMPILED_WHEEL_VARIANT", main_variant)
commit = os.getenv(
"VLLM_PRECOMPILED_WHEEL_COMMIT",
Expand All @@ -696,15 +696,15 @@ def _fetch_metadata_for_variant(
wheels, repo_url, download_filename = None, None, None
try:
wheels, repo_url = _fetch_metadata_for_variant(commit, variant)
except Exception:
except Exception as e:
logger.warning(
"Failed to fetch precompiled wheel metadata for variant %s",
"Failed to fetch precompiled wheel metadata for variant %s: %s",
variant,
exc_info=True,
e,
)
try_default = True # try outside handler to keep the stacktrace simple
if try_default:
logger.info("Trying the default variant")
logger.info("Trying the default variant from remote")
wheels, repo_url = _fetch_metadata_for_variant(commit, None)
# if this also fails, then we have nothing more to try / cache
assert wheels is not None and repo_url is not None, (
Expand All @@ -724,6 +724,8 @@ def _fetch_metadata_for_variant(
"path": "../vllm-0.11.2.dev278%2Bgdbc3d9991-cp38-abi3-manylinux1_x86_64.whl"
},
...]"""
from urllib.parse import urljoin

for wheel in wheels:
# TODO: maybe check more compatibility later? (python_tag, abi_tag, etc)
if wheel.get("package_name") == "vllm" and arch in wheel.get(
Expand All @@ -732,7 +734,7 @@ def _fetch_metadata_for_variant(
logger.info("Found precompiled wheel metadata: %s", wheel)
if "path" not in wheel:
raise ValueError(f"Wheel metadata missing path: {wheel}")
wheel_url = repo_url + wheel["path"]
wheel_url = urljoin(repo_url, wheel["path"])
download_filename = wheel.get("filename")
logger.info("Using precompiled wheel URL: %s", wheel_url)
break
Expand Down
Loading