Skip to content

Conversation

@yewentao256
Copy link
Member

@yewentao256 yewentao256 commented Dec 1, 2025

Purpose

FIx https://buildkite.com/vllm/ci/builds/41328#019adb74-3db0-49ce-84fd-34859b6d7ff3

I can't reproduce this locally, let's run CI and see if it could be solved.

Signed-off-by: yewentao256 <zhyanwentao@126.com>
@yewentao256 yewentao256 added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 1, 2025
@chatgpt-codex-connector
Copy link

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.

@mergify mergify bot added the ci/build label Dec 1, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces changes to setup.py to address a CI failure during Python installation with precompiled binaries. The precompiled_build_ext class is updated to set the build output directory to the project root, which should help in locating the precompiled artifacts correctly. Additionally, the vllm.triton_kernels extension is now excluded from the build process when VLLM_USE_PRECOMPILED is active, preventing a potentially redundant or failing compilation step. The proposed changes are logical and seem to be a reasonable approach to resolving the CI issue. The code is clear and adheres to standard practices. I have not identified any high or critical severity issues in this pull request.

@DarkLight1337
Copy link
Member

We have decided to revert #29690 to fix the issue. Closing as superseded by #29838 which is a patched version of the reverted PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants