Conversation
Batch multiple WAL messages into fewer recv() syscalls by wrapping the stream in a tokio::io::BufReader inside run_on_stream.
Change PgWireError::Io from String to Arc<std::io::Error> so consumers can match on ErrorKind instead of brittle substring matching.
Resolves RUSTSEC-2025-0134 (unmaintained crate). The PemObject trait from rustls-pki-types replaces all rustls-pemfile usage and removes ~70 lines of boilerplate key loading code.
Resolves RUSTSEC-2026-0066 (astral-tokio-tar) and RUSTSEC-2025-0134 (rustls-pemfile via bollard) from transitive dev-dependencies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BufReaderinsiderun_on_stream, batching multiple WAL messages into fewerrecv()syscalls. Reduces syscall overhead significantly during backlog drain scenarios.PgWireError::Ionow wrapsArc<std::io::Error>instead ofString, preservingErrorKindso consumers can match on.kind()(e.g.UnexpectedEof,ConnectionReset) instead of brittle substring matching.Cloneis retained viaArc.Closes #3 and #2 .
Breaking changes
PgWireError::Io(String)->PgWireError::Io(Arc<std::io::Error>)- pattern matches and manual construction sites need updating.Test plan