Skip to content

Class and unit tests refactor #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
matgargano wants to merge 29 commits into
base: master
Choose a base branch
from
Open

Class and unit tests refactor #39

matgargano wants to merge 29 commits into from

Conversation

@matgargano
Copy link

@matgargano matgargano commented Sep 16, 2014

No description provided.

matgargano and others added 29 commits September 8, 2014 17:30
@matgargano
initial commit of unit tests
10ef671
@matgargano
restructure original class to make it testable, hit 100% coverage* (w…
e85df9a 
…ith cc ignores)
@matgargano
fix copypasta issues with phpdoc in helper methods
bd31aa6
@matgargano
set post key in superglobal
20b01fb
@matgargano
fix for test issues
14b36d0
@matgargano
update versions of wordpress to 3.8.4, 3.9.2, 4.0 and latest
400c144
@jeffstieler
Make the tests installer executable.
019f3aa
@jeffstieler
Add trigger_error() testing from http://www.sitepoint.com/testing-err…
48eb2e5 
…or-conditions-with-phpunit/
@jeffstieler
Add default for assertError using PHP’s default error number.
d4fc7b5
@jeffstieler
Remove trigger_error() wrapper and refactor test.
bf2f351
@jeffstieler
Move logic for adding theme support and attaching hooks into separate…
e773801 
… functions.
@jeffstieler
Remove all functions that simply wrap WP core functions.
796d542
@jeffstieler
Don’t call (now nonexistent) WP core function wrappers.
63680e8
@jeffstieler
Missed one call to a WP core function wrapper.
a534699
@jeffstieler
Separate argument parsing logic.
2621995
@jeffstieler
Having parse_arguments() logic separate from register() is difficult …
67c22e0 
…for testing and unnecessary.
@jeffstieler
Update test for register() call.
f08953f
@jeffstieler
Add directory whitelist for code coverage scoping/performance.
fc50613
@jeffstieler
Scope the register() test’s coverage.
999d26b
@jeffstieler
Fix dataProvider hookup for test_register().
4cd1be0
@jeffstieler
Test trigger_registration_error()
5a1d3f1
@jeffstieler
Just add the theme support in register(), add test for it.
6cd96e7
@jeffstieler
Code formatting in attach_hooks().
6962f66
@jeffstieler
Test attach_hooks().
07f244e
@matgargano
add test for test_thumbnail_meta_box
6d3f270
@matgargano
keep test in scope
004e340
@matgargano
refactor class to use shell instance objects
d7714ff
@matgargano
refactor class, update tests
cacf681
@matgargano
add backupGlobal/restoreGlobal methods in favor of global backupGlobals
4e32ba4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jeffstieler jeffstieler

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@matgargano @jeffstieler