Optimize retrieval pipeline and stabilize Next.js lint/type checks#2
Merged
voidcommit-afk merged 4 commits intomainfrom Mar 14, 2026
Merged
Optimize retrieval pipeline and stabilize Next.js lint/type checks#2voidcommit-afk merged 4 commits intomainfrom
voidcommit-afk merged 4 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes several improvements and fixes across the API route handlers, UI components, and utility files. The main themes are improved robustness in API request handling, enhanced translation selection persistence in the chat, and various UI and code quality refinements.
API Route Improvements:
GEThandlers formorphhbandopenhebrewbibleAPI routes. The handlers now check for missing parameters and return a 404 response if necessary, making the endpoints more robust. Also, the response body is now always returned as aUint8Arrayfor consistency. (app/api/morphhb/[book].json/route.tsL71-R77, app/api/morphhb/[book].json/route.tsL108-R112, app/api/openhebrewbible/[layer]/[book]/route.tsL95-R101, app/api/openhebrewbible/[layer]/[book]/route.tsL139-R142)Chat Translation Persistence:
Chat.tsxto use a default and a list of valid translations, and to persist the user's choice inlocalStoragemore reliably. The initialization now happens in the state hook, and updates to the storage occur only when the selection changes, simplifying the effect logic. [1] [2] [3] [4]UI and Accessibility Fixes:
"for quotes andStrong'sfor apostrophes, and updating prop names for clarity (e.g.,reftoverseRef). [1] [2] [3] [4] [5] [6]Popover and Accordion Component Enhancements:
Popovercomponent to simplify context management, improve ref handling, and ensure correct accessibility attributes and event propagation. Also, fixed theAccordionTriggertype to accept the correct props. [1] [2] [3] [4] [5] [6]Code Quality and Maintainability:
Let me know if you'd like to discuss any specific change in more detail!## Summary
This PR consolidates the retrieval optimization work and the follow-up lint/type/build stabilization into a clean, reviewable branch. It improves retrieval observability, caching, ranking, prompt grounding, and rollout benchmarking, and then resolves the React, TypeScript, and Next.js configuration issues needed to keep the branch buildable.
Changes
Verification
Validated with:
Notes
Next.js may auto-update
tsconfig.jsonornext-env.d.tsduring builds by re-adding generated.nexttype includes/imports. The committed versions in this branch intentionally keep those generated imports out of source control, while still allowing the build to complete successfully.