Skip to content

e2e for code interpreter load testing#214

Open
YaoZengzeng wants to merge 2 commits intovolcano-sh:mainfrom
YaoZengzeng:load-warmpool
Open

e2e for code interpreter load testing#214
YaoZengzeng wants to merge 2 commits intovolcano-sh:mainfrom
YaoZengzeng:load-warmpool

Conversation

@YaoZengzeng
Copy link
Member

What type of PR is this?

/kind enhancement

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Signed-off-by: YaoZengzeng <yaozengzeng@huawei.com>
Copilot AI review requested due to automatic review settings February 10, 2026 07:18
@volcano-sh-bot volcano-sh-bot added the kind/enhancement New feature or request label Feb 10, 2026
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from yaozengzeng. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @YaoZengzeng, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces comprehensive end-to-end load testing capabilities for the code interpreter feature. It aims to validate the performance and reliability of both warm pool and standard invocation scenarios under simulated stress, ensuring the system can handle expected traffic volumes effectively.

Highlights

  • New Load Testing Utility: Introduced a generic runCodeInterpreterLoadTest function to execute load tests with configurable requests per second, duration, and output message format. This function handles concurrent requests, session management, command execution, and result aggregation.
  • Warm Pool Load Test: Added TestCodeInterpreterWarmPoolLoad to specifically test the code interpreter's warm pool functionality under a load of 10 requests per second for 10 seconds, ensuring its stability and performance.
  • Basic Invocation Load Test: Included TestCodeInterpreterBasicInvocationLoad to assess the performance of the code interpreter's basic invocation mechanism under a similar load profile (10 requests per second for 10 seconds).

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • test/e2e/e2e_test.go
    • Added loadTestResult struct to encapsulate individual load test request outcomes.
    • Implemented runCodeInterpreterLoadTest function for parameterized load testing of the code interpreter.
    • Created TestCodeInterpreterWarmPoolLoad to perform load testing on code interpreter instances utilizing a warm pool.
    • Developed TestCodeInterpreterBasicInvocationLoad to conduct load testing on standard code interpreter invocations.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces end-to-end load tests for the code interpreter, which is a valuable addition for assessing performance and stability under load. The implementation of the load test is solid, using goroutines for concurrency and a ticker for rate limiting. My review focuses on improving the robustness of the results reporting. I've identified a potential panic when no requests are successful and suggested a fix. I also proposed a change to make the logged statistics clearer in the same zero-success scenario. Overall, great work on adding these important tests.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds E2E load-testing coverage for the Code Interpreter invocation path (including warm pool behavior) to help validate stability and performance under concurrent request pressure.

Changes:

  • Introduces a reusable runCodeInterpreterLoadTest helper that drives request-rate-controlled concurrent invocations and aggregates success/latency stats.
  • Adds two new E2E tests: one for warm pool under load and one for basic (non-warm-pool) invocation under load.

@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2026

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 42.46%. Comparing base (845b798) to head (678913d).
⚠️ Report is 91 commits behind head on main.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #214      +/-   ##
==========================================
+ Coverage   35.60%   42.46%   +6.85%     
==========================================
  Files          29       29              
  Lines        2533     2560      +27     
==========================================
+ Hits          902     1087     +185     
+ Misses       1505     1341     -164     
- Partials      126      132       +6     
Flag Coverage Δ
unittests 42.46% <ø> (+6.85%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: YaoZengzeng <yaozengzeng@huawei.com>
@hzxuzhonghu
Copy link
Member

I am not sure what's case you are testing

@YaoZengzeng
Copy link
Member Author

I am not sure what's case you are testing

load test to avoid failure in #128

@YaoZengzeng
Copy link
Member Author

ping @hzxuzhonghu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/enhancement New feature or request size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments