Skip to content

fix cli dependency#218

Open
warjiang wants to merge 3 commits intovolcano-sh:mainfrom
warjiang:fix/cli-dependency
Open

fix cli dependency#218
warjiang wants to merge 3 commits intovolcano-sh:mainfrom
warjiang:fix/cli-dependency

Conversation

@warjiang
Copy link

What type of PR is this?
/kind bug
/kind documentation

What this PR does / why we need it:

  • fix some shell problem in document
  • make kubernetes as default dependency

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Copilot AI review requested due to automatic review settings February 15, 2026 16:18
@volcano-sh-bot volcano-sh-bot added the kind/bug Something isn't working label Feb 15, 2026
@volcano-sh-bot volcano-sh-bot added the kind/documentation Improvements or additions to documentation label Feb 15, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @warjiang, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a minor documentation error and refactors the project's dependency management. The primary goal is to streamline the installation process by making a critical dependency, Kubernetes, a standard requirement rather than an optional one, while also improving the accuracy of shell command examples in the documentation.

Highlights

  • Documentation Fix: A minor shell syntax issue in the README.md example command has been corrected.
  • Dependency Management: The kubernetes package has been promoted to a default dependency for the CLI, ensuring it's always available without needing to specify optional groups.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • cmd/cli/README.md
    • Removed a trailing backslash from the kubectl agentcube publish command example to fix a shell problem.
  • cmd/cli/pyproject.toml
    • Moved kubernetes>=28.0.0 from the k8s optional dependency group to the main dependencies list.
    • Removed kubernetes>=28.0.0 from the dev optional dependency group.
Activity
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@volcano-sh-bot
Copy link
Contributor

Welcome @warjiang! It looks like this is your first PR to volcano-sh/agentcube 🎉

Signed-off-by: warjiang <1096409085@qq.com>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly fixes a shell command example in the documentation and makes the kubernetes package a core dependency. The changes are logical and well-implemented. I have one minor suggestion to clean up the pyproject.toml file for better maintainability.

Comment on lines 40 to 41
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Since the kubernetes dependency has been moved to the core dependencies, this k8s optional dependency group is now empty and can be removed for better clarity and maintainability.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes two minor issues in the AgentCube CLI: a shell syntax error in the documentation and a dependency configuration issue. The kubernetes library is moved from optional to required dependencies since it's used by core CLI functionality (both the AgentCube and K8s deployment providers).

Changes:

  • Moved kubernetes>=28.0.0 from optional to required dependencies in pyproject.toml
  • Fixed shell syntax by removing trailing backslash from kubectl command in README

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
cmd/cli/pyproject.toml Moved kubernetes dependency from optional (k8s and dev groups) to main dependencies list
cmd/cli/README.md Removed erroneous trailing backslash from kubectl agentcube publish command example

Comment on lines 40 to 41
Copy link

Copilot AI Feb 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'k8s' optional dependency group is now empty after moving kubernetes to the main dependencies. Consider removing this empty optional dependency group entirely to avoid confusion, unless it's being kept for backwards compatibility. If keeping it for backwards compatibility, consider adding a comment explaining this.

Copilot uses AI. Check for mistakes.
Signed-off-by: warjiang <1096409085@qq.com>
Signed-off-by: warjiang <1096409085@qq.com>
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hzxuzhonghu for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 42.04%. Comparing base (845b798) to head (b463bea).
⚠️ Report is 99 commits behind head on main.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #218      +/-   ##
==========================================
+ Coverage   35.60%   42.04%   +6.43%     
==========================================
  Files          29       30       +1     
  Lines        2533     2590      +57     
==========================================
+ Hits          902     1089     +187     
+ Misses       1505     1369     -136     
- Partials      126      132       +6     
Flag Coverage Δ
unittests 42.04% <ø> (+6.43%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug Something isn't working kind/documentation Improvements or additions to documentation size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments