doc: update sample url for router & workload_manager#219
doc: update sample url for router & workload_manager#219warjiang wants to merge 1 commit intovolcano-sh:mainfrom
Conversation
Signed-off-by: warjiang <1096409085@qq.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Summary of ChangesHello @warjiang, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on improving the accuracy of the project's documentation by updating sample service URLs. The changes ensure that the provided examples for Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the sample URLs for the router and workload manager in the AgentRun-CLI-Design.md documentation file. The changes correct the service names and add the port number, aligning the example configuration with the current service definitions. This is a helpful documentation fix that improves accuracy for developers. The changes are correct and look good.
There was a problem hiding this comment.
Pull request overview
Updates the AgentRun CLI design doc’s sample agent_metadata.yaml to reflect the current in-cluster Kubernetes Service DNS names for AgentCube Router and Workload Manager.
Changes:
- Update
router_urlsample tohttp://agentcube-router.agentcube.svc:8080 - Update
workload_manager_urlsample tohttp://workloadmanager.agentcube.svc:8080
| router_url: http://agentcube-router.agentcube.svc:8080 | ||
| workload_manager_url: http://workloadmanager.agentcube.svc:8080 |
There was a problem hiding this comment.
There are still repo examples referencing the old Router service DNS (e.g., example/pcap-analyzer/deployment.yaml uses ROUTER_URL=http://router.agentcube.svc.cluster.local:8080). Consider updating those to agentcube-router as well to keep examples consistent and avoid user confusion.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #219 +/- ##
==========================================
+ Coverage 35.60% 42.04% +6.43%
==========================================
Files 29 30 +1
Lines 2533 2590 +57
==========================================
+ Hits 902 1089 +187
+ Misses 1505 1369 -136
- Partials 126 132 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
What type of PR is this?
/kind documentation
What this PR does / why we need it:
it seems that the example outdated, the latest svc name as following:

btw the original document missing port for
router_urlandworkload_manager_urlWhich issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: