Skip to content

doc: update sample url for router & workload_manager#219

Open
warjiang wants to merge 1 commit intovolcano-sh:mainfrom
warjiang:update_endpoint
Open

doc: update sample url for router & workload_manager#219
warjiang wants to merge 1 commit intovolcano-sh:mainfrom
warjiang:update_endpoint

Conversation

@warjiang
Copy link

@warjiang warjiang commented Feb 17, 2026

What type of PR is this?
/kind documentation

What this PR does / why we need it:

it seems that the example outdated, the latest svc name as following:
image

btw the original document missing port for router_url and workload_manager_url

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: warjiang <1096409085@qq.com>
Copilot AI review requested due to automatic review settings February 17, 2026 16:34
@volcano-sh-bot volcano-sh-bot added the kind/documentation Improvements or additions to documentation label Feb 17, 2026
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hzxuzhonghu for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @warjiang, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on improving the accuracy of the project's documentation by updating sample service URLs. The changes ensure that the provided examples for router_url and workload_manager_url in the docs/design/AgentRun-CLI-Design.md file are current and functional, preventing user confusion and improving the overall usability of the design document.

Highlights

  • Documentation Correction: Corrected outdated sample URLs for router_url and workload_manager_url in the AgentRun-CLI-Design.md document, ensuring the examples reflect current service names and ports.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • docs/design/AgentRun-CLI-Design.md
    • Updated the router_url from http://router.agentcube.svc to http://agentcube-router.agentcube.svc:8080.
    • Updated the workload_manager_url from http://workload-manager.agentcube.svc to http://workloadmanager.agentcube.svc:8080.
Activity
  • The pull request was opened by warjiang to update outdated sample URLs in the documentation.
  • No further review activity or comments have been recorded yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the sample URLs for the router and workload manager in the AgentRun-CLI-Design.md documentation file. The changes correct the service names and add the port number, aligning the example configuration with the current service definitions. This is a helpful documentation fix that improves accuracy for developers. The changes are correct and look good.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the AgentRun CLI design doc’s sample agent_metadata.yaml to reflect the current in-cluster Kubernetes Service DNS names for AgentCube Router and Workload Manager.

Changes:

  • Update router_url sample to http://agentcube-router.agentcube.svc:8080
  • Update workload_manager_url sample to http://workloadmanager.agentcube.svc:8080

Comment on lines +294 to +295
router_url: http://agentcube-router.agentcube.svc:8080
workload_manager_url: http://workloadmanager.agentcube.svc:8080
Copy link

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still repo examples referencing the old Router service DNS (e.g., example/pcap-analyzer/deployment.yaml uses ROUTER_URL=http://router.agentcube.svc.cluster.local:8080). Consider updating those to agentcube-router as well to keep examples consistent and avoid user confusion.

Copilot uses AI. Check for mistakes.
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 42.04%. Comparing base (845b798) to head (f2ac392).
⚠️ Report is 99 commits behind head on main.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #219      +/-   ##
==========================================
+ Coverage   35.60%   42.04%   +6.43%     
==========================================
  Files          29       30       +1     
  Lines        2533     2590      +57     
==========================================
+ Hits          902     1089     +187     
+ Misses       1505     1369     -136     
- Partials      126      132       +6     
Flag Coverage Δ
unittests 42.04% <ø> (+6.43%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/documentation Improvements or additions to documentation size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments