fix issue79: Add support for golang 1.24 and dgx-spark GB10 GPU #80
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| /* | ||
| Copyright 2025 The Volcano Authors. | ||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package nvidia | ||
|
|
||
| // int8Slice wraps an []int8 with more functions. | ||
| type int8Slice []int8 | ||
|
|
||
| // String turns a nil terminated int8Slice into a string | ||
| func (s int8Slice) String() string { | ||
| var b []byte | ||
| for _, c := range s { | ||
| if c == 0 { | ||
| break | ||
| } | ||
| b = append(b, byte(c)) | ||
| } | ||
| return string(b) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,54 @@ | ||||||||||||||
| package nvidia | ||||||||||||||
|
|
||||||||||||||
| import ( | ||||||||||||||
| "bytes" | ||||||||||||||
| "fmt" | ||||||||||||||
| "os/exec" | ||||||||||||||
| "strconv" | ||||||||||||||
| "strings" | ||||||||||||||
|
|
||||||||||||||
| "k8s.io/klog/v2" | ||||||||||||||
| ) | ||||||||||||||
|
|
||||||||||||||
| // GetHostMemory runs `free -b` and parses total/used/free (in bytes), | ||||||||||||||
| // supporting both English and localized (e.g. Chinese) output. | ||||||||||||||
| func GetHostMemory() (uint64, error) { | ||||||||||||||
| cmd := exec.Command("free", "-b") | ||||||||||||||
| var out bytes.Buffer | ||||||||||||||
| cmd.Stdout = &out | ||||||||||||||
| cmd.Stderr = &out | ||||||||||||||
|
|
||||||||||||||
| if err := cmd.Run(); err != nil { | ||||||||||||||
| return 0, fmt.Errorf("failed to run 'free -b': %v, output: %s", err, out.String()) | ||||||||||||||
| } | ||||||||||||||
|
|
||||||||||||||
| lines := strings.Split(strings.TrimSpace(out.String()), "\n") | ||||||||||||||
| if len(lines) < 2 { | ||||||||||||||
| return 0, fmt.Errorf("unexpected 'free' output: %s", out.String()) | ||||||||||||||
| } | ||||||||||||||
|
|
||||||||||||||
| // find the first line that looks like data (numeric second field) | ||||||||||||||
| for _, line := range lines { | ||||||||||||||
| fields := strings.Fields(line) | ||||||||||||||
| if len(fields) < 3 { | ||||||||||||||
| continue | ||||||||||||||
| } | ||||||||||||||
| // skip header lines (contain non-digit in second field) | ||||||||||||||
| if _, err := strconv.ParseUint(strings.ReplaceAll(fields[1], ",", ""), 10, 64); err != nil { | ||||||||||||||
| continue | ||||||||||||||
| } | ||||||||||||||
|
|
||||||||||||||
| // found the data line | ||||||||||||||
| total, err1 := strconv.ParseUint(fields[1], 10, 64) | ||||||||||||||
| used, err2 := strconv.ParseUint(fields[2], 10, 64) | ||||||||||||||
| free, err3 := strconv.ParseUint(fields[3], 10, 64) | ||||||||||||||
|
Comment on lines
+42
to
+44
There was a problem hiding this comment. The check on line 37 correctly handles commas in the memory value by using
Suggested change
|
||||||||||||||
| if err1 != nil || err2 != nil || err3 != nil { | ||||||||||||||
| return 0, fmt.Errorf("parse error: %v %v %v", err1, err2, err3) | ||||||||||||||
| } | ||||||||||||||
|
|
||||||||||||||
| klog.Infof("get system memory total: %dGB, used: %dGB, free: %dGB", total/1024/1024/1024, used/1024/1024/1024, free/1024/1024/1024) | ||||||||||||||
| return total, nil | ||||||||||||||
| } | ||||||||||||||
|
|
||||||||||||||
| return 0, fmt.Errorf("no memory data line found in 'free' output") | ||||||||||||||
| } | ||||||||||||||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better maintainability, it's recommended to define the Go version as a build argument (
ARG) instead of hardcoding it. Please addARG GOLANG_VERSION=1.23.7before this line and then use${GOLANG_VERSION}here.