Skip to content

ci: enhance PR review with severity classification and checklist #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhoujh01 merged 2 commits into from
Mar 5, 2026
Merged

ci: enhance PR review with severity classification and checklist #437

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
604ba7b
ci: enhance PR review with severity classification and review checklist
qin-ctx Mar 5, 2026
2aba685
ci: remove unused num_code_suggestions from pr_reviewer config
qin-ctx Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .github/workflows/pr-review.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,3 +25,17 @@ jobs:
github_action_config.auto_review: "true"
github_action_config.auto_describe: "false"
github_action_config.auto_improve: "true"
pr_reviewer.extra_instructions: >
Classify each finding with a severity tag:
[Bug] = Must fix: behavioral regression, logic error, security vulnerability, data loss/corruption, resource leak, API contract violation.
[Suggestion] = Recommended: missing tests, dead code, inconsistency, poor observability, unclear intent, unrelated changes, performance issues (N+1 queries, redundant computation in loops, unnecessary large object copies, unbounded collection growth).

Review focus areas:
1. Control Flow - are all branches reachable? errors propagated correctly? unintended fall-through?
2. Data Flow - input validated at boundaries? implicit type coercion? null/empty handled?
3. Integration Points - API changes backward compatible? config defaults sensible? dependencies pinned?
4. Concurrency - shared state synchronized? execution order assumptions valid? cleanup in all paths?

Be specific: reference exact variable names, function calls, conditions.
When suggesting a fix, include a code block with the recommended change.
Match the language of the PR (Chinese PR = Chinese comments, English PR = English comments).
Loading