feat(client): add account/user params for root key multi-tenant auth#767
Merged
yeshion23333 merged 1 commit intomainfrom Mar 19, 2026
Merged
feat(client): add account/user params for root key multi-tenant auth#767yeshion23333 merged 1 commit intomainfrom
yeshion23333 merged 1 commit intomainfrom
Conversation
SDK HTTP client now supports account and user parameters so root key holders can access tenant-scoped data APIs without being rejected by the server explicit-tenant requirement. Co-Authored-By: Claude Opus 4.6
|
|
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
yeshion23333
approved these changes
Mar 19, 2026
chethanuk
added a commit
to chethanuk/OpenViking
that referenced
this pull request
Mar 19, 2026
- Add .pr_agent.toml with 15 repo-specific review rules derived from real bug history (PRs volcengine#505, volcengine#728, volcengine#749, volcengine#740/volcengine#745, volcengine#754, volcengine#735, volcengine#767) - Rules structured as WHEN/THEN/BECAUSE for deterministic enforcement - Add 8 custom labels (memory-pipeline, async-change, api-breaking, etc.) - Add ignore patterns for lock files, third_party, build artifacts - Enable score review, TODO scan, split-PR detection, security audit - Configure improve tool with quality threshold and extended mode - Configure describe tool with PR diagrams and semantic file types - Update workflow: ark-code-latest model, checkout step for .pr_agent.toml, move all config from inline YAML to .pr_agent.toml (single source of truth)
4 tasks
qin-ctx
pushed a commit
that referenced
this pull request
Mar 19, 2026
…#780) - Add .pr_agent.toml with 15 repo-specific review rules derived from real bug history (PRs #505, #728, #749, #740/#745, #754, #735, #767) - Rules structured as WHEN/THEN/BECAUSE for deterministic enforcement - Add 8 custom labels (memory-pipeline, async-change, api-breaking, etc.) - Add ignore patterns for lock files, third_party, build artifacts - Enable score review, TODO scan, split-PR detection, security audit - Configure improve tool with quality threshold and extended mode - Configure describe tool with PR diagrams and semantic file types - Update workflow: ark-code-latest model, checkout step for .pr_agent.toml, move all config from inline YAML to .pr_agent.toml (single source of truth)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When
root_api_keyis enabled, the server requiresX-OpenViking-AccountandX-OpenViking-Userheaders for tenant-scoped data APIs (ls, find, sessions, etc.). The SDK HTTP clients (AsyncHTTPClient/SyncHTTPClient) had no way to set these headers, causing all root-key data requests to fail withInvalidArgumentError.This PR adds
accountanduserparameters to the SDK clients and updates the authentication docs accordingly.Related Issue
N/A
Type of Change
Changes Made
AsyncHTTPClient.__init__: addedaccountanduseroptional params, read fromovcli.confwhen not providedAsyncHTTPClient.initialize: sendsX-OpenViking-Account/X-OpenViking-Userheaders when setSyncHTTPClient.__init__: forwardsaccountandusertoAsyncHTTPClientdocs/zh/guides/04-authentication.md: added "使用 Root Key 访问租户数据" section with curl, SDK, and config examplesdocs/en/guides/04-authentication.md: added "Accessing Tenant Data with Root Key" sectionTesting
Checklist
Screenshots (if applicable)
N/A
Additional Notes
All new params default to
None, fully backward compatible with existing call sites.