Skip to content

fix(bot): root key add account\user#770

Merged
qin-ctx merged 1 commit intomainfrom
fix_root_header
Mar 19, 2026
Merged

fix(bot): root key add account\user#770
qin-ctx merged 1 commit intomainfrom
fix_root_header

Conversation

@yeshion23333
Copy link
Collaborator

@yeshion23333 yeshion23333 commented Mar 19, 2026

Description

when use root_api_key, ov http client add account, user params

Related Issue

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes)
  • Performance improvement
  • Test update

Changes Made

Testing

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have tested this on the following platforms:
    • Linux
    • macOS
    • Windows

Checklist

  • My code follows the project's coding style
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

Screenshots (if applicable)

Additional Notes

@github-actions
Copy link

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Config Validation

Ensure openviking_config.account_id and openviking_config.admin_user_id are properly validated (non-null/non-empty) when root_api_key is used, to avoid passing invalid parameters to the AsyncHTTPClient.

self.client = ov.AsyncHTTPClient(
    url=openviking_config.server_url,
    api_key=openviking_config.root_api_key,
    account=openviking_config.account_id,
    user=openviking_config.admin_user_id,
    agent_id=agent_id,
)

@qin-ctx qin-ctx merged commit 9d59d6b into main Mar 19, 2026
5 checks passed
@qin-ctx qin-ctx deleted the fix_root_header branch March 19, 2026 08:33
@github-project-automation github-project-automation bot moved this from Backlog to Done in OpenViking project Mar 19, 2026
@github-actions
Copy link

PR Code Suggestions ✨

No code suggestions found for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants