add engine_kwargs in vllm_rollout_spmd to set params in vllm engine
#1442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangyongxin121
changed the title
engine_kwargs in vllm_rollout_spmd to set swap_space in vllmengine_kwargs in vllm_rollout_spmd to set params in vllm engine
eric-haibin-lin
approved these changes
May 18, 2025
|
@eric-haibin-lin @vermouth1992 shall we merge? |
yellowbee686
pushed a commit
to yellowbee686/verl
that referenced
this pull request
May 22, 2025
…n vllm engine (volcengine#1442) ### Checklist Before Starting - [x] Search for similar PR(s). ### What does this PR do? > add `engine_kwargs` in vllm_rollout_spmd to set swap_space in vllm engine. ### Specific Changes > add `engine_kwargs` in vllm_rollout_spmd, which can be set in config file. Same changes has been made in vllm_rollout. As the version of vllm is update to 0.8, the default vllm_rollout worker becomes vllm_rollout_spmd, which does not have `engine_kwargs` as in vllm_rollout, so this RP want to complete it. ### Usage Example > users can set vllm engine param such as `swap_space`, `seed` through the `engine_kwargs` in config file. For example, if one want to set the swap_space=32 in vllm, he can set the item in config like this ```bash actor_rollout_ref.rollout.engine_kwargs.swap_space=32 ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist Before Starting
What does this PR do?
Specific Changes
Usage Example