Skip to content

Refactor Code (feedback)#11

Open
vonvick wants to merge 36 commits intodevelopmentfrom
chore/refactor-clean-up-code
Open

Refactor Code (feedback)#11
vonvick wants to merge 36 commits intodevelopmentfrom
chore/refactor-clean-up-code

Conversation

@vonvick
Copy link
Owner

@vonvick vonvick commented Feb 28, 2017

What does this PR do?

This PR implements the feedback received from other fellows before the defense

Description of Task to be completed?

Implement feedback received from reviewers

How should this be manually tested?

Not Applicable

Any background context you want to provide?

Not Applicable

What are the relevant pivotal tracker stories?

Not Applicable

Screenshots (if appropriate)

Not Applicable

Questions:

Not Applicable

@coveralls
Copy link

Coverage Status

Coverage increased (+0.4%) to 95.556% when pulling 9516c00 on chore/refactor-clean-up-code into fd6b0db on development.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.4%) to 95.556% when pulling aa72a15 on chore/refactor-clean-up-code into fd6b0db on development.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.4%) to 95.556% when pulling 3fbb26a on chore/refactor-clean-up-code into fd6b0db on development.

@coveralls
Copy link

Coverage Status

Coverage increased (+3.4%) to 98.494% when pulling d1eb815 on chore/refactor-clean-up-code into fd6b0db on development.

victor nwaiwu added 4 commits March 3, 2017 08:06
refactor and create helper functions ro handle errors and transform query result
add more test to check  for create admin method and delete admin methods
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.2%) to 93.883% when pulling 9eb275f on chore/refactor-clean-up-code into fd6b0db on development.

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.3%) to 92.844% when pulling 15eafe2 on chore/refactor-clean-up-code into fd6b0db on development.

@coveralls
Copy link

Coverage Status

Coverage decreased (-82.6%) to 12.556% when pulling 15e4f94 on chore/refactor-clean-up-code into fd6b0db on development.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.7%) to 93.381% when pulling 9d0df8b on chore/refactor-clean-up-code into fd6b0db on development.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.7%) to 93.381% when pulling 58d73a6 on chore/refactor-clean-up-code into fd6b0db on development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants