Open
Conversation
Added method to retrieve message by ID.
master-bob
suggested changes
Apr 13, 2017
master-bob
left a comment
master-bob
left a comment
There was a problem hiding this comment.
The potential for issues arises out of having Wiser.java setting the ID as an int value and WiserMessage.java accepting longs for IDs.
For example:
I can imagine a scenario where a user sets an ID for a WiserMessage as a non-int long, and then attempts to retrieve that ID from Wiser and would get a null.
My recommendation would be to make the ID int based throughout as that is the limitation provided by ArrayList.
|
|
||
| /** | ||
| * Get message identifier | ||
| */ |
|
|
||
| /** | ||
| * Set message identifier | ||
| */ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To build a Java version of mailcatcher (test-tool that serves as an SMTP server, keeps all mail and provides a webinterface to browse messages received, see http://mailcatcher.me/), that can be deployed as a .war, I needed messages to have an ID (number) and a reception date. So I added those two attributes. Plus a method to retrieve a message by ID.
The mailcatcher lookalike will be in a separate project.