manage gpg key with apt::keyring

[techsk8]

Fixes

W: https://artifacts.elastic.co/packages/7.x/apt/dists/stable/InRelease: Key is stored in legacy trusted.gpg keyring (/etc/apt/trusted.gpg), see the DEPRECATION section in apt-key(8) for details.

[smortex]

LGTM, added another reviewer as I do not use these modules and might miss something.

[techsk8]

any news?

[h-haaks]

Hi @techsk8

As far as I know the code already create the keyring file in /etc/apt/keyrings/elastic-keyring.asc.
Ref https://github.com/puppetlabs/puppetlabs-apt/blob/main/manifests/source.pp#L13

I'm afraid managing apt::keyring in this module won't solve your issue ..

Are you having this issue on a fresh/new server or are you upgrading a server that already has the old gpg key installed?

[h-haaks]

could you please share the content of /etc/apt/sources.list.d/elastic.list and the output of apt-key list

[h-haaks]

I suspect your issue is related to module upgrade 9.x -> 10.0.0
9.x adds the pgp-key in /etc/apt/trusted.gpg with key_id '46095ACC8548582C1A2699A9D27D666CD88E42B4'
10.0.0 adds the keyring in /etc/apt/keyrings/elastic-keyring.asc but does not remove the key in /etc/apt/trusted.gpg

If I'm right `sudo apt-key del 46095ACC8548582C1A2699A9D27D666CD88E42B4' should solve this.