Skip to content

Fix group ownership for pip.conf on FreeBSD #739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 1, 2025
Merged

Fix group ownership for pip.conf on FreeBSD #739

merged 3 commits into from
Nov 1, 2025

Conversation

@Szparki
Copy link
Contributor

@Szparki Szparki commented Oct 30, 2025 •
edited by smortex
Loading

Pull Request (PR) description

Fixing pip.conf group ownership on FreeBSD

This Pull Request (PR) fixes the following issues

Fixes #738

@Szparki Szparki mentioned this pull request Oct 30, 2025
Closed
@smortex
Copy link
Member

smortex commented Oct 30, 2025

REFERENCE.md is outdated

Please update REFERENCE.md with

$ bundle exec rake strings:generate:reference

Add it to the PR and CI should continue.\

@bastelfreak bastelfreak added the bug Something isn't working label Oct 30, 2025
@smortex smortex linked an issue Nov 1, 2025 that may be closed by this pull request
pip.conf in hieradata - FreeBSD #738
Closed
@smortex
Include python class before testing python::dotfile
5c5a5bc 
If the python class was not included in the catalog first,
python::params has not been loaded, so the required group is undef
causing compilation failure.
smortex
smortex approved these changes Nov 1, 2025
View reviewed changes
Copy link
Member

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, there was some more issues related to testing and how the module is designed. I fixed it in another commit. Thank you!

@smortex smortex changed the title Fix group ownership for pip.conf Fix group ownership for pip.conf on FreeBSD Nov 1, 2025
@smortex smortex merged commit 40a84a9 into voxpupuli:master Nov 1, 2025
16 checks passed
@Szparki Szparki deleted the fix-group branch November 1, 2025 07:01
@Szparki
Copy link
Contributor Author

Szparki commented Nov 1, 2025

Awesome, thank you @smortex !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smortex smortex smortex approved these changes

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

pip.conf in hieradata - FreeBSD

3 participants

@Szparki @smortex @bastelfreak