Fix ESM bare directory imports causing ERR_UNSUPPORTED_DIR_IMPORT#27
Open
kalahari wants to merge 1 commit intovoyage-ai:mainfrom
Open
Fix ESM bare directory imports causing ERR_UNSUPPORTED_DIR_IMPORT#27kalahari wants to merge 1 commit intovoyage-ai:mainfrom
kalahari wants to merge 1 commit intovoyage-ai:mainfrom
Conversation
The ESM build rename script only rewrote imports ending with .js to .mjs, but left bare imports (e.g. "../api", "./tokenizer") untouched. Node.js ESM does not support directory imports or extensionless imports, causing ERR_UNSUPPORTED_DIR_IMPORT at runtime. Add resolution for bare imports: directories get /index.mjs appended, files get .mjs appended. Fixes voyage-ai#26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/rename-to-esm-files.js) to resolve bare directory/file imports that lack file extensions../api) are rewritten to../api/index.mjs../Client) are rewritten to../Client.mjs.js, leaving extensionless imports untouchedFixes #26
Test plan
pnpm buildsucceeds with no bare imports remaining indist/esm/node -e "import { VoyageAIClient } from 'voyageai'" --input-type=modulenode -e "const { VoyageAIClient } = require('voyageai')"pnpm test:unit— all 421 tests passpnpm run check— no new lint issues introduced