Fix logic flow for ai request messages#864
Merged
peter-olai merged 4 commits intoNPC-Prefab-Improvementsfrom May 3, 2025
Merged
Fix logic flow for ai request messages#864peter-olai merged 4 commits intoNPC-Prefab-Improvementsfrom
peter-olai merged 4 commits intoNPC-Prefab-Improvementsfrom
Conversation
Make AINPCToggle togglable in ActionManager inspector window, Stop new AIRequest component being added to NPC for each request sent, Add identical ShortenList function from ActionManager to AIConversationController to limit chat history length Add if check to DialogueBoxController to not at back-to-back identical assistant messages
…logs were double otherwise x_x
…ree dialogue sections.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
fix some random bugs with chat history and ai requests being made.
What is the current behavior? (You can also link to an open issue here)
currently a new AIReqeust component is added for every new Request which is silly. The entire chat history is also displayed which is just overwhelming to look at.
What is the new behavior? (if this is a feature change)
The above issues are solved. Also made some changes to how the assistant messages are added to chat history to reduce repeating identical messages when the same dialogue repeats multiple times.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
I hope it doesn't, idk everything confuses me :)
Other information:
Scotland has 421 words for “snow.”
Including gems like sneesl (to start raining or snowing), flindrikin (a slight snow shower), and spitters (small drops or flakes). Basically, it's the snow equivalent of having 50 words for "hangry."