fix: change a bunch of variable names, documentation and other genera…#865
Merged
HaluBoi merged 4 commits intoNPC-Prefab-Improvementsfrom May 4, 2025
Merged
fix: change a bunch of variable names, documentation and other genera…#865HaluBoi merged 4 commits intoNPC-Prefab-Improvementsfrom
HaluBoi merged 4 commits intoNPC-Prefab-Improvementsfrom
Conversation
…l changes to reflect standard VR4VET coding conventions
Author
|
hold on, found some issues >_< |
… our team initially due to errors occuring in Unity that are hard to fix on short time
…eceptionOutdoor and Laboratory
HaluBoi
commented
May 4, 2025
Author
HaluBoi
left a comment
HaluBoi
left a comment
There was a problem hiding this comment.
Just merging this since the rest of the team is unavailable atm.
Author
|
forgot to update the description woops |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…l changes to reflect standard VR4VET coding conventions
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
docs update so that code reflects VR4VET coding conventions
What is the current behavior? (You can also link to an open issue here)
Some variables were named incorrectly, and some functions were missing summaries to explain usage.
What is the new behavior? (if this is a feature change)
Next to all the code our team has been working on has been modified to fit the VR4VET coding conventions. In doing so a lot of changes were made to other scripts, but it shouldn't be more than name changes.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Hopefully the changed names for certain variables shouldn't cause too many issue (knocks wood or whatever)
Other information:
There’s a basketball court on the top floor of the U.S. Supreme Court.
It’s nicknamed “The Highest Court in the Land.” 🏀👨⚖️
Justice... with a jump shot.