fix: validate cart loop shipping simulation / logged #3174
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
Infinite loop occurred when validating cart when:
You can try simulate the problem here
How it works?
getOrderFormEtagto filter only fields that indicate real cart changes.nullimmediately when changes.length === 0, ignoring potential need to update shippingData, now we ensures shippingData is updated when necessary (If no changes in the items, but shippingData need to be updated, we update only the shippingData, avoiding inconsistent states.Scenarios that I've tested:
testing_fix_changin_postalCode.mov
testing-no-item.mov
Starters Deploy Preview
preview link
lunellifsacc)The items should be updating according in the card.
References