-
Notifications
You must be signed in to change notification settings - Fork 80
chore: change namings from i18n to localization #3176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 📝 WalkthroughWalkthroughA systematic refactoring renames internationalization (i18n) terminology to localization across configuration, components, and stylesheets. Component names, props, type interfaces, DOM attributes, and import paths are consistently updated from i18n variants to localization variants throughout the codebase. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
13ff950 to
bf4ba8f
Compare
8bf54f0 to
3f1d7e4
Compare
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@packages/core/src/sdk/localization/useBindingSelector.ts`:
- Line 68: The code reads storeConfig.i18n which doesn't exist; update the
assignment that defines localizationConfig (in useBindingSelector) to read
storeConfig.localization instead so localizationConfig is the expected
LocalizationConfig object used later (e.g., localizationConfig.locales,
localizationConfig.regions), or alternatively ensure the app's discovery config
supplies a top-level i18n property with the full LocalizationConfig; prefer
changing the access to storeConfig.localization to match existing
discovery.config keys.
hellofanny
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanksss!
I think we can just add this change for now.
🎗️ run cms sync after merging this PR 😬
4d934ef to
fd60a5a
Compare
70249c2 to
16592cb
Compare
0ca5672 to
9102ec3
Compare
What's the purpose of this pull request?
Change
I18nButtonandI18nSelectortoLocalizationButtonandLocalizationSelector.How it works?
Changed the components, styles and CMS sections names.
How to test it?
I've synced with
brandlessaccount and published the Global Sections.Starters Deploy Preview
References
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.