Skip to content

Conversation

@lariciamota
Copy link
Contributor

@lariciamota lariciamota commented Jan 16, 2026

What's the purpose of this pull request?

Change I18nButton and I18nSelector to LocalizationButton and LocalizationSelector.

How it works?

Changed the components, styles and CMS sections names.

How to test it?

I've synced with brandless account and published the Global Sections.

Starters Deploy Preview

References

  • Slack threads: [1] and [2]

Summary by CodeRabbit

  • Refactor
    • Renamed Internationalization terminology to Localization throughout the user interface for improved clarity and consistency. Updated button labels, selector components, and navigation elements to reflect the new naming convention.

✏️ Tip: You can customize this high-level summary in your review settings.

@lariciamota lariciamota self-assigned this Jan 16, 2026
@lariciamota lariciamota added the enhancement New feature or request label Jan 16, 2026
@lariciamota lariciamota marked this pull request as ready for review January 16, 2026 15:10
@lariciamota lariciamota requested a review from a team as a code owner January 16, 2026 15:10
@lariciamota lariciamota requested review from hellofanny and ommeirelles and removed request for a team January 16, 2026 15:10
@coderabbitai
Copy link

coderabbitai bot commented Jan 16, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

📝 Walkthrough

Walkthrough

A systematic refactoring renames internationalization (i18n) terminology to localization across configuration, components, and stylesheets. Component names, props, type interfaces, DOM attributes, and import paths are consistently updated from i18n variants to localization variants throughout the codebase.

Changes

Cohort / File(s) Change Summary
CMS Schema Configuration
packages/core/cms/faststore/sections.json
Renamed section keys and titles: i18nButtonlocalizationButton, i18nSelectorlocalizationSelector; internal field shouldDisplayI18nButtonshouldDisplayLocalizationButton
Localization Button Component
packages/core/src/components/ui/LocalizationButton/LocalizationButton.tsx, packages/core/src/components/ui/LocalizationButton/index.ts
Renamed component default export I18nButtonLocalizationButton; renamed props interface I18nButtonPropsLocalizationButtonProps; updated imports and data attributes from data-fs-i18n-button-*data-fs-localization-button-*
Localization Selector Component
packages/core/src/components/localization/LocalizationSelector/LocalizationSelector.tsx, packages/core/src/components/localization/LocalizationSelector/index.ts, packages/core/src/components/localization/LocalizationSelector/section.module.scss, packages/core/src/components/localization/index.ts
Renamed component default export I18nSelectorLocalizationSelector; renamed props interfaces and internal component from I18nSelector*LocalizationSelector*; updated data attributes from data-fs-i18n-selector-*data-fs-localization-selector-*; added new re-export at localization index
Removed i18n Component Exports
packages/core/src/components/i18n/I18nSelector/index.ts, packages/core/src/components/i18n/index.ts, packages/core/src/components/ui/I18nButton/index.ts
Removed public re-exports of I18nButton and I18nSelector components
Navigation Components
packages/core/src/components/navigation/Navbar/Navbar.tsx, packages/core/src/components/navigation/NavbarSlider/NavbarSlider.tsx, packages/core/src/components/sections/Navbar/Navbar.tsx
Updated props destructuring and usage: i18nButton/i18nSelectorlocalizationButton/localizationSelector; renamed internal variables (i18nIconlocalizationIcon, i18nTitlelocalizationTitle, etc.); replaced component imports from I18nButton to LocalizationButton
SDK and Hook Updates
packages/core/src/pages/_app.tsx, packages/core/src/sdk/localization/useBindingSelector.ts
Updated import paths to use src/sdk/localization instead of src/sdk/i18n; renamed internal variable i18nConfiglocalizationConfig with updated references
Test Files
packages/core/test/sdk/localization/bindingSelector.test.ts, packages/core/test/sdk/localization/useBindingSelector.test.tsx
Updated import paths to resolve from src/sdk/localization instead of src/sdk/i18n
Stylesheet Updates
packages/ui/src/components/organisms/LocalizationSelector/styles.scss, packages/ui/src/components/organisms/Navbar/styles.scss, packages/ui/src/components/organisms/NavbarSlider/styles.scss, packages/ui/src/styles/components.scss
Renamed CSS attribute selectors from [data-fs-i18n-button]/[data-fs-i18n-selector-*] to [data-fs-localization-button]/[data-fs-localization-selector-*]; updated SCSS import paths for component stylesheets

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

🐰 Hoppity-hop through code we go,
Old i18n names had to blow,
Now localization's the freshest speak,
Components renamed, patterns sleek! ✨
Data attributes hopped along too,
A refactoring dance, sparkling new! 🌟

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 40.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and accurately describes the main change: renaming conventions from 'i18n' to 'localization' across components, props, and related artifacts.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 16, 2026

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@lariciamota lariciamota force-pushed the feat/logic-i18n-selector branch 2 times, most recently from 13ff950 to bf4ba8f Compare January 20, 2026 11:25
@lariciamota lariciamota force-pushed the feat/localization-renaming branch from 8bf54f0 to 3f1d7e4 Compare January 20, 2026 12:30
@lariciamota
Copy link
Contributor Author

@coderabbitai review

@coderabbitai
Copy link

coderabbitai bot commented Jan 20, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@packages/core/src/sdk/localization/useBindingSelector.ts`:
- Line 68: The code reads storeConfig.i18n which doesn't exist; update the
assignment that defines localizationConfig (in useBindingSelector) to read
storeConfig.localization instead so localizationConfig is the expected
LocalizationConfig object used later (e.g., localizationConfig.locales,
localizationConfig.regions), or alternatively ensure the app's discovery config
supplies a top-level i18n property with the full LocalizationConfig; prefer
changing the access to storeConfig.localization to match existing
discovery.config keys.

Copy link
Contributor

@hellofanny hellofanny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanksss!
I think we can just add this change for now.

🎗️ run cms sync after merging this PR 😬

@lariciamota lariciamota force-pushed the feat/logic-i18n-selector branch from 4d934ef to fd60a5a Compare January 20, 2026 14:42
@lariciamota lariciamota force-pushed the feat/localization-renaming branch from 70249c2 to 16592cb Compare January 20, 2026 14:50
Base automatically changed from feat/logic-i18n-selector to feat/multilanguage January 20, 2026 17:23
@lariciamota lariciamota force-pushed the feat/localization-renaming branch from 0ca5672 to 9102ec3 Compare January 20, 2026 17:31
@lariciamota lariciamota merged commit ed88192 into feat/multilanguage Jan 20, 2026
5 of 6 checks passed
@lariciamota lariciamota deleted the feat/localization-renaming branch January 20, 2026 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants