Bumping test column number for exportFileRepositoryListing #505 #506
Conversation
|
Line 11 in 8767356 You might want to update FILE_REPOSITORY_EMPTY_FRAME as well. |
|
The updates to exportFileRepositoryListing look good, and the version‑based column handling makes sense. One small follow‑up: FILE_REPOSITORY_EMPTY_FRAME probably needs to be updated as well. Older REDCap servers will just return two extra empty columns when no data is present, so the behavioral impact is minimal, but keeping the constant aligned with the new six‑column structure would help maintain consistency and avoid subtle mismatches in downstream parsing. |
jubilee2
left a comment
jubilee2
left a comment
There was a problem hiding this comment.
You might want to update FILE_REPOSITORY_EMPTY_FRAME as well.
|
[ FAIL 0 | WARN 0 | SKIP 16 | PASS 2056 ] |
|
Would it be better to move "FILE_REPOSITORY_EMPTY_FRAME" to redcapDataStructure.R? |
Co-authored-by: jubilee2 <jubilee2@gmail.com>
…dcapDataStructure #505
Done. It certainly isn't that constant anymore. |
|
Why does github say "Jubilee2 Rrequested changes" but won't show me what he wants or let me dismiss it? |
|
His suggested change is outdated because you've resolved it |
Prep for next release (assumes they bump the version number) #505