-
-
Notifications
You must be signed in to change notification settings - Fork 8.8k
fix(compiler-sfc): transform empty srcset w/ includeAbsolute: true #13639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughA guard was added in the Changes
Sequence Diagram(s)sequenceDiagram
participant TestRunner
participant Compiler
participant transformSrcset
TestRunner->>Compiler: Compile template with <img srcset=" ">
Compiler->>transformSrcset: Process srcset attribute
transformSrcset->>transformSrcset: Call shouldProcessUrl(url)
alt url is falsy (empty string)
transformSrcset-->>Compiler: Skip processing
else url is valid
transformSrcset-->>Compiler: Process URL as usual
end
Compiler-->>TestRunner: Return compiled code
Assessment against linked issues
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
🔇 Additional comments (2)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Size ReportBundles
Usages
|
@vue/compiler-core
@vue/compiler-dom
@vue/compiler-sfc
@vue/compiler-ssr
@vue/reactivity
@vue/runtime-core
@vue/runtime-dom
@vue/server-renderer
@vue/shared
vue
@vue/compat
commit: |
close vitejs/vite-plugin-vue#631
Summary by CodeRabbit
Bug Fixes
Tests