Adds style failing test case for Vue Testing Library #439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! Sorry for the slow reply. Can you try merging in master and pushing to see if CI passes? |
(cherry picked from commit f7895dd)
|
@lmiller1990 Thanks for the reply. I've force-pushed pulling the changes from master. |
|
I enabled CI for this PR, let's see how it goes. |
|
I think the test is still failing... In any case, could you double check if my test is testing the right thing? As in, it should work that way? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test case reproducing issue #438.
From master, I ran
yarn add @testing-library/vue --dev, and also had to bump@vue/test-utilsto1.3.0otherwise it wouldn't work. I probably messed up something in theyarn.lockfile so apologies for that.I believe
window.getComputedStyleAPI would work to assert this behavior based on it working here (https://codesandbox.io/s/vue-testing-sample-input-forked-drjsm?file=/src/components/Button.test.js). Let me know if there's a better way of testing that.I'm not sure if this is the reproducible case you were looking for so if there's something else I can/should do please let me know so I can improve this PR. Thank you!