Update Testing Actions Documentation to No Longer Reference inject-loader
#2155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… it no longer works and causes confusion for beginners. Use the existing spy implementation instead.
✅ Deploy Preview for vuex-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR removes references to
inject-loaderfrom the Testing Actions section.inject-loaderis no longer working/supported, based on this issue: vuejs/vue-cli#947I fell into the same trap (that others have expressed in that ticket) of trying to get my tests to work following the example code, but only to find out that the
inject-loaderexample code no longer works.I hope that by removing the example code that doesn't work, it can save other newbies like me some time.
I also added a Jest example in case that can be helpful to others.
Sorry if this PR is not the right format. I tried to follow the contribution guidelines, but could not find a version 4 branch or a
devbranch in the repo.Please let me know if there's anything else I should modify.
Thanks for building such a great product and providing well-written documentation. 🙏