Skip to content

Conversation

@zhouLion
Copy link
Contributor

@zhouLion zhouLion commented Nov 11, 2025

  • Main task: to add a web preview component.
  • Additional, integrate Vitest for ensuring consistency with the implementation on the React side.

Maybe the Vitest integration can be split into separate PRs, but how about let's start from here.

@cwandev
Copy link
Collaborator

cwandev commented Nov 12, 2025

Thanks for your work, @zhouLion — great job! 🎉

Regarding the integration of the test suite, I think this is a good starting point.

@peoray what do you think?

@peoray
Copy link
Collaborator

peoray commented Nov 12, 2025

@zhouLion is this ready or still a draft?

@zhouLion
Copy link
Contributor Author

zhouLion commented Nov 12, 2025

@zhouLion is this ready or still a draft?
It's basically done. Manually installing that part requires some code, and I consider using the named slot to replace the loading prop of WebPreviewBody.

@peoray
Copy link
Collaborator

peoray commented Nov 12, 2025

@zhouLion, sorry for the merge conflicts. If you run into any issues, let me know :)

@zhouLion zhouLion force-pushed the zhoulion/web-preview branch from 95b1773 to bf216fe Compare November 13, 2025 08:34
@zhouLion zhouLion marked this pull request as ready for review November 13, 2025 08:34
@zhouLion zhouLion requested a review from peoray November 13, 2025 08:40
@zhouLion
Copy link
Contributor Author

@zhouLion, sorry for the merge conflicts. If you run into any issues, let me know :)

The main branch has been rebased and code conflicts resolved. It's ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants