fix: resolve codeformatter test failures and compilation errors#53
Merged
fix: resolve codeformatter test failures and compilation errors#53
Conversation
- Fix compilation error in css_selector_test.go (html package shadowing) - Fix test expectations: change literal \n to actual newlines - Fix CSS descendant selector to respect ancestor relationships - Fix XML attribute matching to handle any attribute order - Fix nested XML extraction test to properly count elements - Add support for element.class selectors (e.g., div.header) - Add support for double quotes in XPath expressions All tests now passing.
c2a250d to
af93459
Compare
Minimum allowed line rate is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes multiple test failures and a compilation error in the
internal/codeformatterpackage:htmlwas shadowing thehtmlpackage import incss_selector_test.go\nto actual newline characters in test assertionsChanges
New Features
div.header)//book[@id="bk101"])>) vs any descendant (space) selectorsBug Fixes
findElementsByDescendantto properly parse and execute chained selectorsextractElementByAttributeto search attributes regardless of orderapplyXPathFilterto recognize double-quoted attribute valuesTest Plan
go test ./...)Testing
go test ./...All 8 test packages passing ✅