T8065: Dehardcode qemu settings to allow run tests on arch arm64 #1073
+203
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
sever-sever
force-pushed
the
T8065
branch
5 times, most recently
from
faa1b8a to
be1db15
Compare
Member
Author
|
@asklymenko add your review, please |
Member
Author
|
@huihuimoe, do you have a chance to check it? |
sever-sever
force-pushed
the
T8065
branch
2 times, most recently
from
16b0ef3 to
582f2e3
Compare
sever-sever
force-pushed
the
T8065
branch
5 times, most recently
from
1e3e98c to
4fb2337
Compare
c-po
reviewed
Dec 12, 2025
| .ONESHELL: | ||
| test-no-interfaces-no-vpp: checkiso | ||
| scripts/check-qemu-install --debug --configd --smoketest --uefi --no-interfaces --no-vpp build/live-image-amd64.hybrid.iso | ||
| scripts/check-qemu-install --debug --configd --smoketest --uefi --no-interfaces --no-vpp --arch $(arch) build/live-image-$(arch).hybrid.iso |
Member
There was a problem hiding this comment.
Why pass arch explicitly? It could be derived from the image name?
Member
Author
There was a problem hiding this comment.
Because depends on arch we set specific to architecture qemu commands in the “check-qemu-install” script. Image name will not help here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change summary
Dehardcode qemu settings to allow running smoketests on the arch
arm64I cannot completely check it, due to a lack of arm64 devices with a supported
/dev/kvmBut it is a good starting point. It could still fail on the arm64, but at least we allow it for future investigation.
Types of changes
Related Task(s)
Related PR(s)
#1074
Checklist: