Specify that the requests error should go back to the unset state#471
Closed
Specify that the requests error should go back to the unset state#471
Conversation
While running `asynchronously execute a request`, `request`'s `error` is set to `undefined`. For most people this would mean the JS value `undefined`, but in this case, its supposed to go back to the unset state.
Collaborator
|
Hi @stelar7, thanks for the change. Could you please elaborate more on why this change is required? The language |
Contributor
Author
|
Having the spec say It might just feel that way to me because this is the only field that has the concept of I'm fine with closing this if you think the current text clearer in wrt. how the specs are written |
Collaborator
|
I think the current text is probably OK. Setting to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While running
asynchronously execute a request,request'serroris set toundefined.In most cases this would mean the JS value
undefined, but in this case, its supposed to go back to the unset state.Im not sure if there is a better spec wording for this 😅
The following tasks have been completed:
Implementation commitment:
Preview | Diff