Fix incorrect role specified for html element - 571 #2504
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes #571 changes the listed mapping for the html element to be the generic role, rather than the document role. A note is added to clarify the document role of a web page is exposed by a parent `document node` created by the user agent.
✅ Deploy Preview for wai-aria ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
scottaohara
added a commit
to w3c/html-aria
that referenced
this pull request
Apr 1, 2025
per w3c/aria#2504 - the html element doesn't actually map to the `document` role - rather a parent `document node` to the `html` element is what exposes the `document` role of a web page. This update fixes the spec to match the updated HTML aam mapping / matches reality. The `generic` role is being added as an "allowed" but not recommended role to the `html` element. The `document` role is being kept as an allowed role for the `html` element. The rational there being that this has been in the spec for a long time and even when specified on the html element, from what i can tell, there's no pro/con to its inclusion.
pkra
approved these changes
Apr 2, 2025
jnurthen
approved these changes
Apr 3, 2025
cookiecrook
requested changes
Apr 3, 2025
incorporating feedback from #2504 (comment)
spectranaut
moved this from All PRS
to Needs Consensus/Review
in ARIA Normative PR Tracking
|
@cookiecrook it sounds like your issue was resolved, can you positively review this? |
|
I've edited the top card to point to the html-aam issue. |
cookiecrook
approved these changes
Jun 26, 2025
keithamus
approved these changes
Jun 26, 2025
github-project-automation
bot
moved this from Needs Review
to Waiting For Implementation
in ARIA Normative PR Tracking
github-actions bot
added a commit
that referenced
this pull request
Jun 27, 2025
SHA: df5d60a Reason: push, by scottaohara Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes w3c/html-aam#571
changes the listed mapping for the html element to be the generic role, rather than the document role.
A note is added to clarify the document role of a web page is exposed by a parent
document nodecreated by the user agent.From what i can tell, no implementation bugs need to be filed, as browsers have been doing the right thing - and this is a spec correction to match reality.
Preview | Diff