#429: Have SHACL-SHACL warn about unsatisfiable usage of sh:in and sh:xone
#451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…:xone
This patch revises part of the implementation in PR 417.
* `in-minListLength` was not added to the Core document, but it was
referenced in SHACL-SHACL. Verbiage is added to Core in line with the
text drafted for Issue 429.
* `xone-memberShape` was added as a reference in SHACL-SHACL, but
doesn't exist in the Core document. `xone-members-node` is the anchor
in the Core document. `xone-members-node` is now used.
* The `PropertyShape` for `sh:in` set a minimum required length of 1,
which after discussion in Issue 429 appears to be a backward-
incompatible change. A shape paralleling the original suggestion for
`sh:xone` is added to house that new restriction at the same warning-
level severity.
An implementation style point: The property shapes housing
`sh:minListLength` are given IRIs after sketching a test
(`.../in-003.ttl`) and assuming it would be more desirable to have an
IRI-identified shape in the results graph, rather than a blank node.
A testing style point: Rather than running SHACL-SHACL over the whole of
a test, shapes from SHACL-SHACL are copied into some focused tests
(`.../{in,xone}-003.ttl`).
References:
* #429
* #417
Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
jeswr
approved these changes
Aug 4, 2025
|
@ajnelson-nist, can this PR be merged? |
TallTed
reviewed
Oct 16, 2025
Comment on lines
5901
to
+5902
| <span data-syntax-rule="xone-members-node">Each <a>member</a> of such list must be a <a>well-formed</a> <a>shape</a>.</span> | ||
| <span data-syntax-rule="xone-minListLength">There should be at least one <a>member</a> of such list.</span> |
There was a problem hiding this comment.
If these are not intended to be RFC2119 keywords, it's best to not use them, even in lowercase, to avoid common confusion.
Suggested change
| <span data-syntax-rule="xone-members-node">Each <a>member</a> of such list must be a <a>well-formed</a> <a>shape</a>.</span> | |
| <span data-syntax-rule="xone-minListLength">There should be at least one <a>member</a> of such list.</span> | |
| <span data-syntax-rule="xone-members-node">Each <a>member</a> of such list <em title="MUST in RFC 2119 context" class="rfc2119">MUST</em> be a <a>well-formed</a> <a>shape</a>.</span> | |
| <span data-syntax-rule="xone-minListLength">Each such list <em title="SHOULD in RFC 2119 context" class="rfc2119">SHOULD</em> have at least one <a>member</a>.</span> |
TallTed
reviewed
Oct 16, 2025
| A <a>SHACL list</a> that has the allowed values as <a>members</a>. | ||
| <span data-syntax-rule="in-node">Each value of <code>sh:in</code> in a shape is a <a>SHACL list</a>.</span> | ||
| <span data-syntax-rule="in-maxCount">A shape has at most one value for <code>sh:in</code>.</span> | ||
| <span data-syntax-rule="in-minListLength">There should be at least one <a>member</a> of such list.</span> |
There was a problem hiding this comment.
Suggested change
| <span data-syntax-rule="in-minListLength">There should be at least one <a>member</a> of such list.</span> | |
| <span data-syntax-rule="in-minListLength">Each such list <em title="SHOULD in RFC 2119 context" class="rfc2119">SHOULD</em> have at least one <a>member</a>.</span> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #429 .
This patch revises part of the implementation in PR 417.
in-minListLengthwas not added to the Core document, but it was referenced in SHACL-SHACL. Verbiage is added to Core in line with the text drafted for Issue 429.xone-memberShapewas added as a reference in SHACL-SHACL, but doesn't exist in the Core document.xone-members-nodeis the anchor in the Core document.xone-members-nodeis now used.PropertyShapeforsh:inset a minimum required length of 1, which after discussion in Issue 429 appears to be a backward- incompatible change. A shape paralleling the original suggestion forsh:xoneis added to house that new restriction at the same warning- level severity.An implementation style point: The property shapes housing
sh:minListLengthare given IRIs after sketching a test (.../in-003.ttl) and assuming it would be more desirable to have an IRI-identified shape in the results graph, rather than a blank node.A testing style point: Rather than running SHACL-SHACL over the whole of a test, shapes from SHACL-SHACL are copied into some focused tests (
.../{in,xone}-003.ttl).