Skip to content

Conversation

@ottomorac
Copy link
Contributor

@ottomorac ottomorac commented Jan 6, 2026

This PR addresses #228, it clarifies the example usage of how to call the resolve function in the Implementer Overview paragraph.


Preview | Diff

index.html Outdated
Comment on lines 203 to 209
For example, a wallet app could resolve <code>did:example:123</code>
using the `versionTime` resolution option for instance:
<code>resolve("did:example:123", {"versionTime":"2021-05-10T17:00:00Z"})</code>
to retrieve the state of that DID at a past time. Or a client could dereference a DID URL
like <code>did:example:123?service=files&relativeRef=/resume.pdf</code>
(see <a href="#example-dereferencing-to-service-endpoint-url">here for detailed example</a>)
to fetch a user's resume stored via a service declared in the DID document.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
For example, a wallet app could resolve <code>did:example:123</code>
using the `versionTime` resolution option for instance:
<code>resolve("did:example:123", {"versionTime":"2021-05-10T17:00:00Z"})</code>
to retrieve the state of that DID at a past time. Or a client could dereference a DID URL
like <code>did:example:123?service=files&relativeRef=/resume.pdf</code>
(see <a href="#example-dereferencing-to-service-endpoint-url">here for detailed example</a>)
to fetch a user's resume stored via a service declared in the DID document.
For example, to retrieve the state of the DID <code>did:example:123</code>
at a past time, a wallet app could resolve the DID with the `versionTime`
resolution option, as in the following:<br>
<code>resolve("did:example:123", {"versionTime":"2021-05-10T17:00:00Z"})</code>
Or, to fetch a user's resume stored via a service declared in the DID
document, a client could dereference a DID URL like this:
<code>did:example:123?service=files&relativeRef=/resume.pdf</code>
(See <a href="#example-dereferencing-to-service-endpoint-url">a more
detailed example</a>.)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the DID URL Path discussion, we may want to avoid using relativeRef in this example.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @TallTed for the observation on clarity. I will update the PR with your wording on the first example.

Also thanks to @wip-abramson for the observation around the second example using relativeRef. However my PR is not intended to modify that second example. Perhaps we can address in a separate issue after the DID Path discussion is more settled?

@ottomorac ottomorac closed this Jan 9, 2026
@ottomorac ottomorac force-pushed the ottomorac-fix-implementer-example branch from b16fbdb to 843a7d8 Compare January 9, 2026 18:47
@ottomorac
Copy link
Contributor Author

Updated PR with changes suggested by @talltree

@ottomorac ottomorac reopened this Jan 9, 2026
@msporny msporny changed the base branch from gh-pages to main January 11, 2026 20:22
@msporny msporny self-requested a review as a code owner January 11, 2026 20:42
For example, a wallet app could resolve `did:example:123?versionTime=2021-05-10T17:00:00Z`
using the `versionTime` parameter to retrieve the state of that DID at a past time, or a client could
For example, to retrieve the state of the DID `did:example:123`
at a past time, a wallet app could resolve the DID with the `versionTime`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
at a past time, a wallet app could resolve the DID with the `versionTime`
at a past time, a client application could resolve the DID with the `versionTime`

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
at a past time, a wallet app could resolve the DID with the `versionTime`
at a time in the past, a client application could resolve the DID with the `versionTime`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants